[test] make tx6 child of tx5, not tx3, in rbf_tests #25820

pull glozow wants to merge 1 commits into bitcoin:master from glozow:2022-08-rbf-test-fix changing 1 files +1 −1
  1. glozow commented at 11:52 AM on August 11, 2022: member

    A small overlooked oopsie from #25674. There is no effect on the test results because tx3 and tx5 pay the same fee, but this was the intended configuration, as the comment suggests.

  2. [test] make tx6 child of tx5, not tx3, in rbf_tests
    There is no effect on the test results because tx3 and tx5 pay the say
    fee, but this was the intended configuration, as the comment suggests.
    49db42cdf5
  3. fanquake added the label Tests on Aug 11, 2022
  4. fanquake requested review from instagibbs on Aug 11, 2022
  5. fanquake requested review from ariard on Aug 11, 2022
  6. fanquake requested review from darosior on Aug 11, 2022
  7. darosior approved
  8. darosior commented at 12:54 PM on August 11, 2022: member

    Github diff ACK 49db42cdf56be1a76ab381d37870aa45e17ab666. Should have catched this. :/

  9. instagibbs commented at 1:12 PM on August 11, 2022: member

    more descriptive variable names can help avoid this but not going to block fix

    ACK https://github.com/bitcoin/bitcoin/pull/25820/commits/49db42cdf56be1a76ab381d37870aa45e17ab666

  10. fanquake merged this on Aug 11, 2022
  11. fanquake closed this on Aug 11, 2022

  12. sidhujag referenced this in commit 3d6c0a6e81 on Aug 11, 2022
  13. glozow deleted the branch on Aug 12, 2022
  14. bitcoin locked this on Aug 12, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me