wallet: consolidate CoinSelectionParams::m_change_target and m_min_change_target #25825

1. 
   glozow commented at 4:31 pm on August 11, 2022: member

   These values are both intended for the same thing. Their divergence seems to be the result of an incomplete rename.
2. [coin selection] consolidate m_change_target and m_min_change_target

   These values are both intended for the same thing. Their divergence
   seems to be the result of an incomplete rename.

   acda7e8686
3. glozow added the label Wallet on Aug 11, 2022
4. glozow requested review from S3RK on Aug 11, 2022
5. glozow requested review from achow101 on Aug 11, 2022
6. glozow requested review from murchandamus on Aug 11, 2022
7. 
   achow101 commented at 5:31 pm on August 11, 2022: member

   ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048
8. furszy approved
9. 
   furszy commented at 5:48 pm on August 11, 2022: member

   ACK acda7e86

   was asking the same in #25647 (review)

10. 
    glozow commented at 6:11 pm on August 11, 2022: member

    (Credit to @S3RK for pointing this out to me)
11. 
    murchandamus commented at 6:31 pm on August 11, 2022: contributor

    ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048

    I’m surprised this didn’t get caught by tests. Perhaps we are missing one for the minimum change. My gut feeling is that it wouldn’t be trivial to test, so that might be out of scope for this PR, though.

12. 
    aureleoules commented at 6:49 pm on August 11, 2022: member

    ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048. Verified m_change_target is unused and m_min_change_target is the variable that should be used.
13. achow101 merged this on Aug 11, 2022
14. achow101 closed this on Aug 11, 2022

    ---

15. glozow deleted the branch on Aug 12, 2022
16. 
    S3RK commented at 7:34 pm on August 12, 2022: contributor

    Post merge ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048.
17. bitcoin deleted a comment on Jan 1, 2023
18. bitcoin locked this on Jan 1, 2024

Contributors
glozow achow101 furszy murchandamus aureleoules S3RK

Review Requested
S3RK achow101 murchandamus

Labels
Wallet