netbase: fix !O_NONBLOCK where ~O_NONBLOCK was meant #2583

1. 
   laanwj commented at 1:44 PM on April 27, 2013: member

   Using ! on a non-zero value will always return 0, so the statement is currently ineffective.

   If this is not what is meant, the respective code in ConnectSocketDirectly to set the socket back to blocking should be removed entirely, as it currently behaves differently for windows and linux.

   Also remove some duplicate and superfluous code in other places.

2. fix !O_NONBLOCK where ~O_NONBLOCK was meant

   Using ! on a non-zero value will always return 0.
   
   Also remove some duplicate and superfluous code in other places.

   fe9e88cb06
3. 
   BitcoinPullTester commented at 2:14 PM on April 27, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fe9e88cb06cf47fc30b122e3c768aa0dc1813e48 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

4. 
   sipa commented at 8:41 PM on April 27, 2013: member

   Wow, apparently introduced by a commit of mine in 0.3.23. I can't even remember I wrote that code or the comment with it...

   ACK

5. sipa referenced this in commit 1c621e70be on Apr 29, 2013
6. sipa merged this on Apr 29, 2013
7. sipa closed this on Apr 29, 2013

   ---

8. laudney referenced this in commit 5d9d89fde0 on Mar 19, 2014
9. laanwj deleted the branch on Apr 9, 2014
10. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2