refactor: Replace m_params with chainman.GetParams() #25830

1. 
   aureleoules commented at 12:01 pm on August 12, 2022: member

   Fixes a TODO introduced in #24595. Removes m_params from CChainState class and replaces it with m_chainman.GetParams().
2. fanquake added the label Validation on Aug 12, 2022
3. fanquake added the label Refactoring on Aug 12, 2022
4. 
   DrahtBot commented at 1:11 am on August 13, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25172 (refactor: use std:: prefix for std lib funcs by fanquake)
   • #20827 (During IBD, prune as much as possible until we get close to where we will eventually keep blocks by luke-jr)
   • #9245 (Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. DrahtBot added the label Needs rebase on Sep 16, 2022
6. aureleoules force-pushed on Sep 16, 2022
7. DrahtBot removed the label Needs rebase on Sep 16, 2022
8. DrahtBot added the label Needs rebase on Oct 10, 2022
9. refactor: Replace m_params with chainman.GetParams()

   Fixes a TODO introduced in #24595.

   5d3f98d278
10. aureleoules force-pushed on Oct 10, 2022
11. DrahtBot removed the label Needs rebase on Oct 10, 2022
12. aureleoules closed this on Oct 12, 2022

    ---

13. 
    maflcko commented at 8:08 am on October 13, 2022: member

    Why the close?
14. 
    aureleoules commented at 8:59 am on October 13, 2022: member

    @MarcoFalke I was asked by @adamjonas to close this during coredev.
15. 
    maflcko commented at 9:27 am on October 13, 2022: member

    It is fixing a TODO, so if that is no longer applicable, the TODO should be removed
16. 
    adamjonas commented at 12:39 pm on October 13, 2022: member

    @MarcoFalke the request to close was based on lack of review and, therefore, the implied lack of support. If you’d be willing to review, @aureleoules can reopen.
17. 
    maflcko commented at 12:46 pm on October 13, 2022: member

    sure
18. aureleoules reopened this on Oct 13, 2022

    ---

19. 
    aureleoules commented at 12:50 pm on October 13, 2022: member

    Note that I could have reduced the code diff by renaming params to m_params but since params is not a class member anymore I think its more confusing.
20. 
    maflcko commented at 8:03 am on October 19, 2022: member

    review ACK 5d3f98d27879cd6d84b8590e947336e8d09613ed 🌎

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3review ACK 5d3f98d27879cd6d84b8590e947336e8d09613ed 🌎
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUjJ8Qv/ct7XpfKidLyXHj8qvtiMkjeM7lH4rtiwWVOi23PmFTl3UXN+CJZwuXlt
     8P7onWWziczOZIJzJVVwFKgbOegIfG2QNWlVpSWsgQRYXYdCi8wRyqmsChxKUNdQ/
     9+Yl2ny0CMpoEORl1rD8/wFdvBhpKbkVDl/dbCKLmz1KUxLfFDWPfcZ2VdyCrtoKr
    10+jXmBUtYVGciQaD/MK638lK/AgBEy1GzbBnnBZKg8oKi729FsEzFY9C7mGFT7OMc
    11RMn2hRKMdl9Vjz5ffBVp7DXC5tHTG6RJMZAIilI6xdw77BX5qFK5+HqGsOh/27sx
    12sn6mA0kP+tqPxV4/lD6PgtoYpbmQN9afxVJ8zFLCOM/TU4gIbQzlApQ1iM4/x+jp
    13m5E3lE0OAmWgns8YQ1ui2VkbcQhPU+0OfzoZC/3VPH5fGF5L2fW0aFsdgy2jT4Ph
    14pIFZjGbXvI8m/WEok1Rps4ZEKcIqkFjK0q3l29gJILPHZNtagEf4s4zqWc7czmtd
    15DiVFo5K1
    16=Udt+
    17-----END PGP SIGNATURE-----
    

21. 
    maflcko commented at 8:05 am on October 19, 2022: member

    In the future it might be best not to add refactoring TODOs?
22. maflcko merged this on Oct 19, 2022
23. maflcko closed this on Oct 19, 2022

    ---

24. aureleoules deleted the branch on Nov 2, 2022
25. bitcoin locked this on Nov 2, 2023

Contributors
aureleoules DrahtBot maflcko adamjonas

Labels
Refactoring Validation