Fixes a TODO introduced in #24595.
Removes m_params from CChainState class and replaces it with m_chainman.GetParams().
refactor: Replace m_params with chainman.GetParams() #25830
pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-08-replace-m_params changing 2 files +38 −35-
aureleoules commented at 12:01 PM on August 12, 2022: member
- fanquake added the label Validation on Aug 12, 2022
- fanquake added the label Refactoring on Aug 12, 2022
-
DrahtBot commented at 1:11 AM on August 13, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25172 (refactor: use std:: prefix for std lib funcs by fanquake)
- #20827 (During IBD, prune as much as possible until we get close to where we will eventually keep blocks by luke-jr)
- #9245 (Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Needs rebase on Sep 16, 2022
- aureleoules force-pushed on Sep 16, 2022
- DrahtBot removed the label Needs rebase on Sep 16, 2022
- DrahtBot added the label Needs rebase on Oct 10, 2022
-
5d3f98d278
refactor: Replace m_params with chainman.GetParams()
Fixes a TODO introduced in #24595.
- aureleoules force-pushed on Oct 10, 2022
- DrahtBot removed the label Needs rebase on Oct 10, 2022
- aureleoules closed this on Oct 12, 2022
-
maflcko commented at 8:08 AM on October 13, 2022: member
Why the close?
-
aureleoules commented at 8:59 AM on October 13, 2022: member
@MarcoFalke I was asked by @adamjonas to close this during coredev.
-
maflcko commented at 9:27 AM on October 13, 2022: member
It is fixing a TODO, so if that is no longer applicable, the TODO should be removed
-
adamjonas commented at 12:39 PM on October 13, 2022: member
@MarcoFalke the request to close was based on lack of review and, therefore, the implied lack of support. If you'd be willing to review, @aureleoules can reopen.
-
maflcko commented at 12:46 PM on October 13, 2022: member
sure
- aureleoules reopened this on Oct 13, 2022
-
aureleoules commented at 12:50 PM on October 13, 2022: member
Note that I could have reduced the code diff by renaming
paramstom_paramsbut sinceparamsis not a class member anymore I think its more confusing. -
maflcko commented at 8:03 AM on October 19, 2022: member
review ACK 5d3f98d27879cd6d84b8590e947336e8d09613ed 🌎
<details><summary>Show signature</summary>
Signature:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 review ACK 5d3f98d27879cd6d84b8590e947336e8d09613ed 🌎 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p pUjJ8Qv/ct7XpfKidLyXHj8qvtiMkjeM7lH4rtiwWVOi23PmFTl3UXN+CJZwuXlt P7onWWziczOZIJzJVVwFKgbOegIfG2QNWlVpSWsgQRYXYdCi8wRyqmsChxKUNdQ/ +Yl2ny0CMpoEORl1rD8/wFdvBhpKbkVDl/dbCKLmz1KUxLfFDWPfcZ2VdyCrtoKr +jXmBUtYVGciQaD/MK638lK/AgBEy1GzbBnnBZKg8oKi729FsEzFY9C7mGFT7OMc RMn2hRKMdl9Vjz5ffBVp7DXC5tHTG6RJMZAIilI6xdw77BX5qFK5+HqGsOh/27sx sn6mA0kP+tqPxV4/lD6PgtoYpbmQN9afxVJ8zFLCOM/TU4gIbQzlApQ1iM4/x+jp m5E3lE0OAmWgns8YQ1ui2VkbcQhPU+0OfzoZC/3VPH5fGF5L2fW0aFsdgy2jT4Ph pIFZjGbXvI8m/WEok1Rps4ZEKcIqkFjK0q3l29gJILPHZNtagEf4s4zqWc7czmtd DiVFo5K1 =Udt+ -----END PGP SIGNATURE-----</details>
-
maflcko commented at 8:05 AM on October 19, 2022: member
In the future it might be best not to add refactoring TODOs?
- maflcko merged this on Oct 19, 2022
- maflcko closed this on Oct 19, 2022
- aureleoules deleted the branch on Nov 2, 2022
- bitcoin locked this on Nov 2, 2023
