Macros should not have a trailing semi-colon to avoid empty statements when using them with another semi-colon. Noticed this while reviewing a PR.
refactor: Remove trailing semicolon from LOCK2 macro #25831
pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-08-macro-trailing-semicolon changing 1 files +1 −1-
aureleoules commented at 12:19 PM on August 12, 2022: member
-
refactor: Remove trailing semicolon from LOCK2 0f0cc05e4c
- DrahtBot added the label Refactoring on Aug 12, 2022
-
DrahtBot commented at 1:10 AM on August 13, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25676 (sync: simplify and remove unused code from sync.h by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- fanquake requested review from vasild on Sep 13, 2022
- vasild approved
-
vasild commented at 10:39 AM on September 14, 2022: contributor
ACK 0f0cc05e4cf6ccdd514a23d8aa916942dfc1e352
I think it is irrelevant whether the
;is there or not. - maflcko merged this on Sep 14, 2022
- maflcko closed this on Sep 14, 2022
- sidhujag referenced this in commit 536acd4db0 on Sep 14, 2022
- aureleoules deleted the branch on Nov 2, 2022
- bitcoin locked this on Nov 2, 2023
Contributors
Labels