WSAStartup only called in BindListenPort #2585

From what I understood, WSAStartup should be called on windows before using any of the other socket functions. According to http://msdn.microsoft.com/en-us/library/windows/desktop/ms742213%28v=vs.85%29.aspx :

The WSAStartup function must be the first Windows Sockets function called by an application or DLL.

However, it is called in BindListenPort which is only called (from init) when fNoListen is not set.

Can a windows dev (@diapolo?) comment on this? Should we move the WSAStartup call some place else?

I can only comment on what I read and you are right. IMHO we should move the WSAStartup call before if (!fNoListen) { in init.cpp to be sure it got called. A little weird that this didn't yet cause more problems though...

Edit: Also the wsadata attributes could be used for adding some debugging information to the log (iMaxSockets for example)?

A wild guess is that qt or some other library that we use initializes it. Or it somehow works in an uninitialized state but that'd be a scary idea...

IMHO this should move to init.cpp