move WSAStartup to init #2586

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_04_winsock_init changing 2 files +8 −12

laanwj commented at 6:55 AM on April 28, 2013: member

WSAStartup should be called before using any other socket functions. BindListenPort is not called if not listening, thus move it to init.

Closes #2585.

move WSAStartup to init

WSAStartup should be called before using any other socket
functions. BindListenPort is not called if not listening.

Closes #2585.

d23fa49c52

BitcoinPullTester commented at 7:36 AM on April 28, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d23fa49c52e9e0310f938379c5af91f0b4e5fe46 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/init.cpp:None in d23fa49c52

 457 | +    // Initialize Windows Sockets
 458 | +    WSADATA wsadata;
 459 | +    int ret = WSAStartup(MAKEWORD(2,2), &wsadata);
 460 | +    if (ret != NO_ERROR)
 461 | +    {
 462 | +        return InitError(strprintf("Error: TCP/IP socket library failed to start (WSAStartup returned error %d)", ret));

Diapolo commented at 1:18 PM on April 28, 2013:

Could this be translated?

laanwj commented at 1:22 PM on April 28, 2013:

It could; but IMO doesn't make sense. The chance of winsock failing initialization is very small, not worth adding an extra (and complex) message to translate.

Diapolo commented at 2:29 PM on April 28, 2013: none

Compiled in and still working :), so ACK.
laanwj referenced this in commit 33029bcedd on Apr 28, 2013
laanwj merged this on Apr 28, 2013
laanwj closed this on Apr 28, 2013
laudney referenced this in commit 6dc103553e on Mar 19, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

BitcoinPullTester

Diapolo

Linked (view graph)

#2585 WSAStartup only called in BindListenPort