wallet: remove UNKNOWN type from OUTPUT_TYPES array #25869

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2022_fix_output_type_fuzz changing 2 files +0 −2
  1. furszy commented at 7:49 pm on August 18, 2022: member

    Fixing #25734 (review) -> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50329

    The OUTPUT_TYPES array contain the known active output types only. And it’s solely used to create/walk-through the active spkms.

    So, no need to add the UNKNOWN type here.

  2. wallet: remove UNKNOWN type from OUTPUT_TYPES array
    This array contains the known active output types only.
    And it's solely used to create/walk-through the active spkms.
    5b4fdbbff5
  3. fanquake added the label Wallet on Aug 18, 2022
  4. DrahtBot commented at 9:26 pm on August 18, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24897 ([Draft / POC] Silent Payments by w0xlt)
    • #23417 (wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101)
    • #22341 (rpc: add getxpub by Sjors)
    • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. w0xlt approved
  6. LarryRuane approved
  7. LarryRuane commented at 5:19 am on August 19, 2022: contributor
    ACK 5b4fdbbff527aef8288edb3bf21b478de1061221
  8. maflcko added this to the milestone 24.0 on Aug 19, 2022
  9. fanquake requested review from achow101 on Aug 19, 2022
  10. achow101 commented at 3:46 pm on August 19, 2022: member
    ACK 5b4fdbbff527aef8288edb3bf21b478de1061221
  11. achow101 merged this on Aug 19, 2022
  12. achow101 closed this on Aug 19, 2022

  13. furszy deleted the branch on May 27, 2023
  14. bitcoin locked this on May 26, 2024


furszy DrahtBot w0xlt LarryRuane achow101


achow101

Labels
Wallet

Milestone
24.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me