tests: Use mocktime for wallet encryption timeout #25878

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:wallet-enc-test-mocktime changing 1 files +7 −11

achow101 commented at 5:53 PM on August 19, 2022: member

The intermittent wallet_encryption.py failures are related to differences in time between python and std::chrono. We can avoid this entirely by using mocktime. This also allows us to test for the exact unlocking time rather than that it is greater than expected.

Fixes #25482
tests: Use mocktime for wallet encryption timeout 02dea9a47f
DrahtBot commented at 6:02 PM on August 19, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25750 (test: Temporarily work around Windows bug in walletpassphrase by MarcoFalke)
- #25021 (test: fix intermittent wallet_encryption failures on win64 task by jonatack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 6:03 PM on August 19, 2022: member

review ACK 02dea9a47fa17e977c9de72233ebd74e913fa30a
MarcoFalke commented at 6:16 PM on August 19, 2022: member

To clarify, this is more of a workaround than a fix for the underlying chrono bug
DrahtBot added the label Tests on Aug 19, 2022
vasild approved
vasild commented at 4:42 AM on August 20, 2022: contributor

ACK 02dea9a47fa17e977c9de72233ebd74e913fa30a
MarcoFalke merged this on Aug 20, 2022
MarcoFalke closed this on Aug 20, 2022
sidhujag referenced this in commit 7031380243 on Aug 20, 2022
bitcoin locked this on Aug 20, 2023

Contributors

Labels

Linked (view graph)

#25482 qa: Intermittent failure in `wallet_encryption.py --descriptors`

tests: Use mocktime for wallet encryption timeout #25878

Conflicts