doc: Clarify multiple wallets for same signer #25882

1. 
   Rspigler commented at 2:22 AM on August 20, 2022: contributor

   Taken from @josibake comment in #22635 and #22678

   Creating new wallets for HWW actually just 'duplicates' and renames existing wallet (from user's POV).

2. MarcoFalke renamed this:
   Clarify multiple wallets for same signer
   doc: Clarify multiple wallets for same signer
   on Aug 20, 2022
3. fanquake added the label Docs on Aug 20, 2022
4. fanquake requested review from Sjors on Aug 20, 2022
5. in doc/external-signer.md:44 in 389484e5f6 outdated

     39 | @@ -40,6 +40,8 @@ Create a wallet, this automatically imports the public keys:
     40 |  $ bitcoin-cli createwallet "hww" true true "" true true true
     41 |  ```
     42 |  
     43 | +Creating `N` distinctly named wallets with the same external signer, will create `N` identical wallets, with the same seed, account, and addresses - just named differently. New wallet creation will not automatically increment the `account` path. 
     44 | +
   

   ---

   ---

   

   jonatack commented at 10:39 AM on August 20, 2022:

   Assuming this changed is correct, you'll need to appease the linter by removing the extra space.

6. Rspigler force-pushed on Aug 21, 2022
7. Rspigler merged this on Aug 21, 2022
8. Rspigler closed this on Aug 21, 2022

   ---

9. Rspigler force-pushed on Aug 21, 2022
10. 
    ghost commented at 2:09 AM on August 21, 2022: none

    @Rspigler do you have commit access in this repository?

11. 
    Rspigler commented at 2:14 AM on August 21, 2022: contributor

    I don't... I'm confused. I think it's a Github bug? Since I don't actually see any changes merged

12. 
    ghost commented at 2:31 AM on August 21, 2022: none

    I don't... I'm confused. I think it's a Github bug? Since I don't actually see any changes merged

    Not surprised because Microsoft owns it. Works same as Windows.

    Maybe we need to restart something.

13. 
    ghost commented at 3:03 AM on August 21, 2022: none

    I don't see it in the category of high or medium or low in this https://bounty.github.com/

    It seems like a vulnerability because everyone using github.com and only looking at this pull request would assume its merged however its not.

    I am assuming it doesn't affect bitcoin core but it would affect a lot of other repositories.

14. 
    ghost commented at 3:06 AM on August 21, 2022: none

    @Rspigler can you share the steps to reproduce privately?

    Email: alicexbt[at]protonmail[dot]com Twitter: https://twitter.com/1440000bytes

15. 
    achow101 commented at 3:27 AM on August 21, 2022: member

    I think what happened is that @Rspigler pushed the current master branch commit to the branch for this PR. Github saw that the commits in the PR branch were in master, and so detects it as merged.

16. 
    Rspigler commented at 3:44 AM on August 21, 2022: contributor

    Yes, exactly. I just tested that again here and it resulted in the same

17. 
    ghost commented at 3:48 AM on August 21, 2022: none

    Awesome

18. MarcoFalke locked this on Aug 21, 2022

Contributors

Rspiglerjonatackghostachow101

Review Requested
Sjors