Some win32-leveldb related fixes #2589

1. 
   sipa commented at 4:17 PM on April 28, 2013: member

   This pull request bundles a few commits with changes that I wrote to discover and fix @Diapolo's problem with LevelDB I/O errors after the maximum number of open files was reduced to 64.

   The first one improves an error message, the second makes sure closing files succeeds, and the third fixes the actual issues (table files being opened by different threads simultaneously).

2. Print actual Win32 error that occurred on file creation failure. 67efbda4a2
3. Checking whether closing succeeds 20d6f2013b
4. Allow files to be opened for reading multiple times 551b367f19
5. 
   Diapolo commented at 4:22 PM on April 28, 2013: none

   Currently testing this, I did a full IBD from one of sipas nodes, now a -reindex is running and I'll do another -reindex with a -dbcache of 1024! Will report my findings here and on IRC.

6. 
   BitcoinPullTester commented at 4:48 PM on April 28, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/551b367f19dce1951362a1f9911004e583732376 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

7. 
   Diapolo commented at 5:16 PM on April 28, 2013: none

   First -reindex finished without errors, now a reindex with -dbcache=1024 is running.

8. 
   Diapolo commented at 6:55 PM on April 28, 2013: none

   Second -reindex finished without errors :), ACK from my side.

9. 
   gavinandresen commented at 1:28 PM on April 29, 2013: contributor

   Changes look good to me, ACK (I didn't test, though).

10. 
    Diapolo commented at 4:21 PM on April 29, 2013: none

    Any chance this can be pushed upstream into the main LevelDB code? Perhaps Google is interested ^^.

11. 
    sipa commented at 11:36 PM on April 29, 2013: member

    @Diapolo The win32 env code is not part of upstream LevelDB. If it matures a bit more, we may try to get it merged though.

12. sipa referenced this in commit d2cefe1674 on Apr 29, 2013
13. sipa merged this on Apr 29, 2013
14. sipa closed this on Apr 29, 2013

    ---

15. sipa deleted the branch on May 3, 2013
16. laudney referenced this in commit e7c726e5d1 on Mar 19, 2014
17. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2