fixups for BIP125 doc cleanup #25902

pull glozow wants to merge 1 commits into bitcoin:master from glozow:2022-08-125-fixup changing 4 files +6 −6

glozow commented at 2:08 PM on August 22, 2022: member
Followups from #25775:

fixups for BIP125 doc cleanup

Grammar and readability fixups.
Clarifies "bip125-replaceable" helpstrings.

375ebadbf8

glozow added the label Docs on Aug 22, 2022
glozow requested review from ariard on Aug 22, 2022
glozow removed review request from ariard on Aug 22, 2022
glozow requested review from MarcoFalke on Aug 22, 2022
glozow requested review from ariard on Aug 22, 2022
MarcoFalke commented at 2:33 PM on August 22, 2022: member

lgtm

in src/rpc/mempool.cpp:258 in 375ebadbf8

 254 | @@ -255,7 +255,7 @@ static std::vector<RPCResult> MempoolEntryDescription()
 255 |              {RPCResult{RPCResult::Type::STR_HEX, "transactionid", "parent transaction id"}}},
 256 |          RPCResult{RPCResult::Type::ARR, "spentby", "unconfirmed transactions spending outputs from this transaction",
 257 |              {RPCResult{RPCResult::Type::STR_HEX, "transactionid", "child transaction id"}}},
 258 | -        RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction could be replaced due to BIP125 (replace-by-fee)"},
 259 | +        RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction signals BIP125 replaceability or has an unconfirmed ancestor signaling BIP125 replaceability.\n"},

MarcoFalke commented at 2:42 PM on August 22, 2022:

For reference, this change adds clarification around the #22209 misunderstanding

glozow commented at 3:17 PM on August 22, 2022:

Yeah, hopefully this can close that.

This comment was helpful background for me: #25575 (comment)

MarcoFalke commented at 3:25 PM on August 22, 2022:

Hmm, depending on the user there might still be a need for just finding out the signal of this tx, not taking into account the ancestors.

So I think we could return two bools, or an enum, see #25575 (comment)

glozow commented at 3:27 PM on August 22, 2022:

So I think we could return two bools, or an enum, see #25575 (comment)

either would make sense imo :shrug:

t-bast approved
t-bast commented at 2:47 PM on August 22, 2022: contributor

ACK https://github.com/bitcoin/bitcoin/pull/25902/commits/375ebadbf8f4bc9568c5280a75a20faa8cf9c31b
ariard commented at 3:25 PM on August 22, 2022: member

ACK 375ebad

Thanks for the fixups
MarcoFalke merged this on Aug 22, 2022
MarcoFalke closed this on Aug 22, 2022
sidhujag referenced this in commit 7778464d03 on Aug 22, 2022
glozow deleted the branch on Aug 23, 2022
bitcoin locked this on Aug 23, 2023

Contributors

Labels

Linked (view graph)

#25775 docs: remove non-signaling mentions of BIP125