p2p: make CJDNS fixed seeds usable #25938

pull mzumsande wants to merge 2 commits into bitcoin:master from mzumsande:202208_fixed_cjdns changing 3 files +4 −2

mzumsande commented at 6:51 PM on August 26, 2022: member

The CJDNS fixed seeds are currently unusable because in order for them to be interpreted as CJDNS, MaybeFlipIPv6toCJDNS needs to be called (which will change their network to CJDNS if that network is reachable). Currently, these entries are interpreted as IPv6 addresses that are unroutable and therefore not added to addrman, so bootstrapping a new onlynet=cjdns node won't work out of the box.

Fix this, and also add CJDNS support to the debug-only addpeeraddress RPC by calling MaybeFlipIPv6toCJDNS there as well.
DrahtBot added the label P2P on Aug 26, 2022

p2p: make CJDNS fixed seeds usable

In order for them to be interpreted as CJDNS,
MaybeFlipIPv6toCJDNS needs to be called. Before,
they would be interpreted as unroutable IPv6 addresses
and not added to addrman.

e6838c6d15

mzumsande force-pushed on Aug 26, 2022
rpc: make addpeeraddress work with cjdns addresses 5f8e02c7da
mzumsande force-pushed on Aug 26, 2022
MarcoFalke added this to the milestone 24.0 on Aug 27, 2022
luke-jr commented at 3:36 AM on August 28, 2022: member

Currently, these entries are interpreted as IPv6 addresses that are unroutable and therefore not added to addrman, so bootstrapping a new onlynet=cjdns node won't work out of the box.

Why is this? chainparamsseeds.h has them set as NET_CJDNS already...
mzumsande commented at 4:12 AM on August 28, 2022: member

Why is this? chainparamsseeds.h has them set as NET_CJDNS already...

Oh, you are right. I'm not sure what I did wrong when I encountered this yesterday while testing out something with cjdns and couldn't connect to the seeds - but I must have confused something because it clearly works like you describe. Closing.
mzumsande closed this on Aug 28, 2022
903803 commented at 6:18 AM on August 28, 2022: none

coin
fanquake locked this on Aug 28, 2022
mzumsande deleted the branch on Aug 28, 2022
fanquake removed this from the milestone 24.0 on Sep 13, 2022

Contributors

Labels