Google Code repo doesn't exist anymore
doc: Fix link to MurmurHash3.cpp (moved from Google Code to Github) #25959
pull dontbyte wants to merge 1 commits into bitcoin:master from dontbyte:patch-1 changing 1 files +1 −1-
dontbyte commented at 11:57 AM on August 30, 2022: contributor
-
2c05dc7811
Fix link to MurmurHash3.cpp from Austin Appleby
Google Code repo doesn't exist anymore
- fanquake added the label Docs on Aug 30, 2022
-
ghost commented at 12:07 PM on August 30, 2022: none
How about removing the external link from the comment?
- unknown approved
- unknown approved
- bitcoin deleted a comment on Aug 30, 2022
- bitcoin deleted a comment on Aug 30, 2022
- bitcoin deleted a comment on Aug 30, 2022
-
Sjors commented at 12:07 PM on August 31, 2022: member
ACK
It's good to keep the attribution and potential context. This matches the 301 redirect in the Way Back Machine. The code itself has diverged quite a lot.
-
Zero-1729 commented at 5:53 AM on September 1, 2022: contributor
crACK 2c05dc7811db4fe61d7f30fc9b46c374f75226c5
nit: it'll be good to have the commit message title include a prefix for more context, e.g.:
doc: Fix link to MurmurHash3.cpp from Austin Appleby - dontbyte renamed this:
Fix link to MurmurHash3.cpp (moved from Google Code to Github)
doc: Fix link to MurmurHash3.cpp (moved from Google Code to Github)
on Sep 1, 2022 - MarcoFalke merged this on Sep 1, 2022
- MarcoFalke closed this on Sep 1, 2022
- sidhujag referenced this in commit d3fcde8104 on Sep 1, 2022
- bitcoin locked this on Sep 1, 2023