QA: rpc_blockchain: Test output of getblock verbosity 0, False, and True #25976

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:qa_rpc_getblock_verbose changing 1 files +10 −0

luke-jr commented at 6:50 PM on September 1, 2022: member

Currently getblock's "verbosity" is documented as a NUM, though it has a fallback to Boolean for the (deprecated?) "verbose" alias.

Since we've been doing more generic type-checking on RPC stuff, I think it would be a good idea to actually test the Boolean values work.

I didn't see an existing test for verbosity=0, so this adds that too.
QA: rpc_blockchain: Test output of getblock verbosity 0, False, and True f663b43df0
DrahtBot added the label Tests on Sep 1, 2022
aureleoules commented at 11:28 AM on September 5, 2022: member

ACK f663b43df041da7777e6f45a8df04fa852f79106. I agree we should check that the verbosity can be a bool or a int. Also verified that assert_hexblock_hashes is correct and that the 160 magic number corresponds to the size of the blockheader in chars.

Should verbosity with bool be marked as deprecated and add a TODO comment to remove it completely later?
MarcoFalke merged this on Sep 5, 2022
MarcoFalke closed this on Sep 5, 2022
sidhujag referenced this in commit 042f48042c on Sep 5, 2022
luke-jr commented at 7:53 PM on September 5, 2022: member

Should verbosity with bool be marked as deprecated and add a TODO comment to remove it completely later?

Maybe, but I'm not sure the compatibility has a cost.
bitcoin locked this on Sep 5, 2023

Contributors

Labels