combinerawtransaction confusing with distinct transactions #25980

1. 
   luke-jr commented at 9:21 pm on September 1, 2022: member

   If passed two unrelated transactions, combinerawtransaction seems to take the first and ignore the rest.

   We should probably either throw an error or actually combine them somehow?

2. luke-jr added the label Bug on Sep 1, 2022
3. willcl-ark added the label good first issue on Oct 14, 2024
4. 
   adamandrews1 commented at 5:48 pm on November 15, 2024: none

   I am working on this issue, will issue a patch soon.
5. 
   adamandrews1 commented at 1:18 am on December 9, 2024: none

   Tagging prior reviewers for new pull request. TYIA @maflcko @achow101
6. 
   oxqnd commented at 2:13 pm on May 1, 2025: none

   Could I try this issue?
7. 
   adamandrews1 commented at 4:42 pm on May 1, 2025: none

   Could I try this issue?

   Would you mind reviewing #31298 instead?

   This solution is still up to date, it just hasn’t gotten the right reviewers.

8. 
   oxqnd commented at 10:43 pm on May 1, 2025: none

   Could I try this issue?

   Would you mind reviewing #31298 instead?

   This solution is still up to date, it just hasn’t gotten the right reviewers.

   I’ll take a look at #31298, but it might take me a little while to get to it. Hope that’s okay!

9. jalateras referenced this in commit 111010eefc on Sep 11, 2025
10. mossein referenced this in commit 2bf6a53365 on Dec 6, 2025
11. 
    mossein commented at 10:24 pm on December 6, 2025: none

    Closing in favor of #31298 which has been in review since November 2024 and addresses the same issue. I wasn’t aware of the existing PRs when I opened this. I’ll contribute by reviewing #31298 instead.

    Apologies for the duplicate!

Contributors
luke-jr adamandrews1 oxqnd mossein

Labels
Bug good first issue