combinerawtransaction confusing with distinct transactions #25980

issue luke-jr opened this issue on September 1, 2022

luke-jr commented at 9:21 PM on September 1, 2022: member

If passed two unrelated transactions, combinerawtransaction seems to take the first and ignore the rest.

We should probably either throw an error or actually combine them somehow?
luke-jr added the label Bug on Sep 1, 2022
willcl-ark added the label good first issue on Oct 14, 2024
adamandrews1 commented at 5:48 PM on November 15, 2024: none

I am working on this issue, will issue a patch soon.
adamandrews1 commented at 1:18 AM on December 9, 2024: none

Tagging prior reviewers for new pull request. TYIA @maflcko @achow101
oxqnd commented at 2:13 PM on May 1, 2025: none

Could I try this issue?
adamandrews1 commented at 4:42 PM on May 1, 2025: none

Could I try this issue?

Would you mind reviewing #31298 instead?

This solution is still up to date, it just hasn't gotten the right reviewers.
oxqnd commented at 10:43 PM on May 1, 2025: none

Could I try this issue?

Would you mind reviewing #31298 instead?

This solution is still up to date, it just hasn't gotten the right reviewers.

I’ll take a look at #31298, but it might take me a little while to get to it. Hope that’s okay!
jalateras referenced this in commit 111010eefc on Sep 11, 2025
mossein referenced this in commit 2bf6a53365 on Dec 6, 2025
mossein commented at 10:24 PM on December 6, 2025: none

Closing in favor of #31298 which has been in review since November 2024 and addresses the same issue. I wasn't aware of the existing PRs when I opened this. I'll contribute by reviewing #31298 instead.

Apologies for the duplicate!
EricGrill referenced this in commit 42a3f7f045 on Jan 13, 2026
maflcko removed the label good first issue on Feb 12, 2026

Contributors

Labels

Linked (view graph)

#31091 rpc: Disallow non-matching transactions in combinerawtransaction #31298 rpc: combinerawtransaction now rejects unmergeable transactions #33361 Fix #25980: Validate transactions in combinerawtransaction #34024 rpc: Reject distinct transactions in combinerawtransaction