test: revert #25865 for wallet_groups.py (quick fix) #25988

pull stickies-v wants to merge 1 commits into bitcoin:master from stickies-v:test-fix-walletgroup-test changing 1 files +0 −3

stickies-v commented at 5:45 PM on September 2, 2022: contributor

Edit: root issue fixed in #25990, closing this.

As described in #25940, test/functional/wallet_groups.py suddenly started failing intermittently. Even though there are no explanations yet, this seems to be significantly exacerbated or introduced by #25865. This PR patches that by reverting the change (only to wallet_groups.py) without addressing the root issue, as to quickly unbreak CI which is failing quite often now.

Should be followed-up with a proper fix since it's not immediately obvious that #25865 should have led to wallet_groups.py failing intermittently.

I did empirical testing to verify that the test started failing because of #25865 by running wallet_groups.py until it failed, first on commit b21e522ce (the HEAD of #25865) and then on a75b7796b (the HEAD right before #25865). On b21e522ce (i.e. with #25865), it took about ~9.2 runs (n=6) on average before the test failed. On the previous commit a75b7796b (i.e. without #25865), I didn't get a single failure after running the test 100 times.

With this PR, I didn't get a single failure after 240 runs.

test: revert #25865 for wallet_groups.py

Since #25865, test/functional/wallet_groups.py started failing
intermittently as described in #25940. This commit patches that
by reverting the change without addressing the root issue, to
quickly unbreak CI. Should be followed-up with a proper fix.

82e7d7b202

DrahtBot added the label Tests on Sep 2, 2022
stickies-v commented at 12:34 AM on September 3, 2022: contributor

Root issue fixed in #25990, closing this.
stickies-v closed this on Sep 3, 2022
stickies-v deleted the branch on Sep 22, 2022
bitcoin locked this on Sep 22, 2023

Contributors

stickies-v

Labels

Tests

Linked (view graph)

#25865 test: speedup wallet tests by whitelisting peers (immediate tx relay)#25940 Intermittent failure in `wallet_groups.py`#25990 test: apply fixed feerate to avoid variable dynamic fees in wallet_groups.py