test: Display skipped tests reason #26031

pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-09-print-test-skip-reason changing 1 files +5 −3

aureleoules commented at 9:21 AM on September 7, 2022: member

Attempt to fix #26023.
fanquake added the label Tests on Sep 7, 2022
kouloumos commented at 11:01 AM on September 7, 2022: contributor

ACK f5a46ab53413679d7f3514c816ef7d893f0019da, looks good and it definitely adds more context to someone running the functional tests to better understand why those tests are skipped.

Note: As most of the skip_test_if_missing_module checks are based on ./configuration options, reviewers can check for different skip reasons just with different configuration parameters instead of re-building.
brunoerg commented at 11:30 AM on September 7, 2022: contributor

Concept ACK

in test/functional/test_runner.py:565 in f5a46ab534 outdated

 562 |              done_str = "{}/{} - {}{}{}".format(i, test_count, BOLD[1], test_result.name, BOLD[0])
 563 |              if test_result.status == "Passed":
 564 |                  logging.debug("%s passed, Duration: %s s" % (done_str, test_result.time))
 565 |              elif test_result.status == "Skipped":
 566 | -                logging.debug("%s skipped" % (done_str))
 567 | +                logging.debug("%s skipped (%s)" % (done_str, reason))

maflcko commented at 7:01 AM on September 8, 2022:

                logging.debug(f"{done_str} skipped ({reason})")

nit: Could use f-strings? Also, could name this skip_reason?

aureleoules commented at 10:42 AM on September 8, 2022:

pushed

maflcko approved
test: Display skipped tests reason 07b6e74314
aureleoules force-pushed on Sep 8, 2022
brunoerg approved
brunoerg commented at 9:08 PM on September 8, 2022: contributor

ACK 07b6e743147f410d8ceb4b6b3282e9fba4cafe50
maflcko merged this on Sep 9, 2022
maflcko closed this on Sep 9, 2022
sidhujag referenced this in commit 158be43158 on Sep 11, 2022
aureleoules deleted the branch on Nov 2, 2022
bitcoin locked this on Nov 2, 2023

Contributors

Labels

Linked (view graph)

#26023 Running functional tests using test_runner.py does NOT display the SkipTest() message