util: improve bitcoin-wallet exit codes #26067

1. 
   MarcoFalke commented at 11:12 am on September 12, 2022: member

   Refactors bitcoin-wallet so that it doesn’t return a non-zero exit code by default, and makes the option handling more inline with the other binaries. i.e outputting Error: too few parameters if you don’t pass any options.

   Fixing this means we can check the process output in gen-manpages.py; which addresses the remaining review comment from #24263.

2. util: improve bitcoin-wallet exit codes fa2b8ae0a2
3. DrahtBot added the label Utils/log/libs on Sep 12, 2022
4. luke-jr approved
5. 
   luke-jr commented at 11:25 pm on September 19, 2022: member

   utACK
6. MarcoFalke merged this on Sep 20, 2022
7. MarcoFalke closed this on Sep 20, 2022

   ---

8. MarcoFalke deleted the branch on Sep 20, 2022
9. sidhujag referenced this in commit 39caeb411b on Sep 20, 2022
10. in contrib/devtools/gen-manpages.py:39 in fa2b8ae0a2

    35@@ -36,7 +36,7 @@
    36 for relpath in BINARIES:
    37     abspath = os.path.join(builddir, relpath)
    38     try:
    39-        r = subprocess.run([abspath, '--version'], stdout=subprocess.PIPE, universal_newlines=True)
    40+        r = subprocess.run([abspath, "--version"], stdout=subprocess.PIPE, check=True, universal_newlines=True)
    

    ---

    ---

    

    Riahiamirreza commented at 5:26 pm on September 23, 2022:

    Why change single quote to double quote? Is it a coding style in the Bitcoin Core?
11. 
    Riahiamirreza commented at 5:45 pm on September 23, 2022: contributor

    As far as I could grasp the codebase, ACK.
12. bitcoin locked this on Sep 23, 2023

Contributors
MarcoFalke luke-jr Riahiamirreza

Labels
Utils/log/libs