Do not write to wallet during LoadWallet #2607

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:loadwalletfix changing 2 files +6 −1
  1. gavinandresen commented at 4:47 PM on May 2, 2013: contributor

    When debugging another issue, I found a hang-during-startup race condition due to LoadWallet calling SetMinVersion (via LoadCryptedKey).

    Writing to the file that you're in the process of reading is a bad idea.

  2. Do not write to wallet during LoadWallet
    When debugging another issue, I found a hang-during-startup race condition due to
    LoadWallet calling SetMinVersion (via LoadCryptedKey).
    
    Writing to the file that you're in the process of reading is a bad idea.
    2f15e86a68
  3. BitcoinPullTester commented at 5:14 PM on May 2, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2f15e86a68aba56a8ea8e01e58b2fb7b71846b51 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. sipa commented at 7:06 PM on May 2, 2013: member

    ACK

  5. gavinandresen referenced this in commit aa62b2c433 on May 3, 2013
  6. gavinandresen merged this on May 3, 2013
  7. gavinandresen closed this on May 3, 2013

  8. gavinandresen deleted the branch on Nov 4, 2013
  9. laudney referenced this in commit 78d75f53b6 on Mar 19, 2014
  10. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me