coin selection: Check whether feerate is higher than long_term_feerate only once #26104

pull murchandamus wants to merge 1 commits into bitcoin:master from murchandamus:2022-09-high-feerate-optimization changing 1 files +2 −1
  1. murchandamus commented at 7:43 PM on September 15, 2022: contributor

    This moves code that is loop invariant outside of the loop and thus will cause us to only evaluate the inequality and fee lookups once instead of every time we get to the backtrack check.

    I would expect this to slightly improve the performance of the backtrack evaluation in the branch and bound algorithm.

  2. fanquake added the label Wallet on Sep 15, 2022
  3. murchandamus force-pushed on Sep 15, 2022
  4. murchandamus renamed this:
    Check whether feerate is higher than long_term_feerate only once
    coin selection: Check whether feerate is higher than long_term_feerate only once
    on Sep 15, 2022
  5. coin selection: Check once whether feerate is high
    Move the evaluation of whether the feerate is higher than the
    long_term_feerate_estimate out of the loop, since it is constant across
    the coin selection attempt.
    
    This should slightly improve the performance of the backtrack evaluation
    in the branch and bound algorithm.
    
    co-authored-by: Yancy Ribbens <email@yancy.lol>
    eda862a607
  6. murchandamus force-pushed on Sep 15, 2022
  7. murchandamus commented at 8:02 PM on September 15, 2022: contributor

    Nevermind, should be an improvement to #25932

  8. murchandamus closed this on Sep 15, 2022

  9. bitcoin locked this on Sep 15, 2023
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me