Script: SCRIPT_VERIFY_SIGPUSHONLY sits unused (except tests) #26113

issue instagibbs opened this issue on September 16, 2022

instagibbs commented at 5:51 PM on September 16, 2022: member

Turns out this flag was added for BIP62, which was withdrawn a long time ago. It's only used in tests, not in policy or consensus otherwise.

If there's no plans on picking the BIP back up, better to remove?

h/t @ajtowns
ajtowns commented at 10:00 AM on September 17, 2022: member

Picking it back up was part of #15482 / the great consensus cleanup, and I don't think there were any objections to that part of it. Not sure how much difference it would make to keep it vs removing it and re-adding it later though.
fanquake added the label Brainstorming on Sep 19, 2022
glozow commented at 10:23 AM on October 6, 2022: member

Maybe it should be policy? :shrug:
instagibbs commented at 1:28 PM on October 6, 2022: member

Great Policy Cleanup incoming?
instagibbs commented at 1:32 PM on October 6, 2022: member

More seriously, the pushonly check is already done in policy via IsStandardTx
hebasto deleted a comment on Oct 7, 2022

Contributors

Labels