test: check that bumping tx with already spent coin fails #26127

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202209-test-bumpfee-check_that_bumping_tx_with_spent_input_fails changing 1 files +13 −2

theStack commented at 6:09 PM on September 19, 2022: contributor

This PR adds missing coverage for the bumpfee RPC, for the case that a wallet transaction is passed with an input that is already spent: https://github.com/bitcoin/bitcoin/blob/0b02ce914e8594e8938e527c91c07f57def4e943/src/wallet/feebumper.cpp#L182-L186

This is achieved by simply creating a transaction with a wallet and then mining it (I'm not aware of any other scenario how this could be achieved). Additionally, two RPC throw checks are changed in the test to be more specific: https://github.com/bitcoin/bitcoin/blob/0b02ce914e8594e8938e527c91c07f57def4e943/src/wallet/feebumper.cpp#L42-L45 https://github.com/bitcoin/bitcoin/blob/0b02ce914e8594e8938e527c91c07f57def4e943/src/wallet/feebumper.cpp#L47-L50
test: check that bumping tx with already spent coin fails 74eb194f81
fanquake added the label Tests on Sep 19, 2022
fanquake requested review from glozow on Sep 19, 2022
glozow commented at 3:16 PM on September 20, 2022: member

ACK 74eb194f8155624c598ede1a3f45545f8d74c9db

Test seems sensible and correct. I didn't exhaustively check for coverage, but indeed seems like this isn't already tested in wallet_bumpfee.py.
MarcoFalke merged this on Sep 20, 2022
MarcoFalke closed this on Sep 20, 2022
theStack deleted the branch on Sep 20, 2022
sidhujag referenced this in commit 430d06b774 on Sep 20, 2022
bitcoin locked this on Sep 20, 2023

Contributors

theStack

glozow

Labels

Tests