Partial solaris support #2618

pull fcicq wants to merge 5 commits into bitcoin:master from fcicq:solaris-support changing 6 files +25 −8
  1. fcicq commented at 6:01 AM on May 5, 2013: contributor

    This pull request are easy to audit changes, other clean up & makefile modification (remove unsupported -Wl,-z,relro in LDHARDENING, add/mod libs) are still required.

    on my build env, I have to explicitly specify std::map for every map, and disable literals in c++11, see http://en.wikipedia.org/wiki/C%2B%2B11#User-defined_literals, which can be done via this batch hack:

    sed -i "s/map</std::map</g" *.cpp *.h
    sed -i "s/std::std::map</std::map</g" *.cpp *.h
    sed -i "s/multistd::map</multimap</g" *.cpp *.h
    sed -i "s/limitedstd::map</limitedmap</g" *.cpp *.h
    sed -i "s/\"PRI/\" PRI/g" *.cpp *.h
    

    then the code will work with either CXXFLAGS=-std=c++11 or unmodified CXXFLAGS(no c++11 enabled).

    the remaining patch for makefile.unix: https://gist.github.com/fcicq/6018268

  2. BitcoinPullTester commented at 6:33 AM on May 5, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e867ecd26cd335150adaafc0921683873dae6017 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  3. BitcoinPullTester commented at 5:35 PM on May 24, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b96fa1dda368808a501b5c2d5ac17ca387962d6e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. in src/util.h:None in b96fa1dda3 outdated
     100 | @@ -101,6 +101,12 @@ T* alignup(T* p)
     101 |  #else
     102 |  #define MAX_PATH            1024
     103 |  #endif
     104 | +// As Solaris does not have the MSG_NOSIGNAL flag for send(2)
     105 | +// syscall,
     106 | +//it is defined as 0
     107 | +#ifndef MSG_NOSIGNAL
     108 | +# define MSG_NOSIGNAL 0
    


    Diapolo commented at 10:01 PM on May 24, 2013:

    Even if it looks nicer, I guess this breaks current coding styles. Same for the change below.


    fcicq commented at 8:08 AM on May 25, 2013:

    @Diapolo Thanks for your comment, and I corrected the mistake that merged the upstream.

  5. BitcoinPullTester commented at 8:59 AM on May 25, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/77f3ceda5d1efb6c5de34c0ce1e2372151caddc7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  6. jgarzik commented at 4:21 PM on May 30, 2013: contributor

    Mostly ACK. Need rebase + resolving the fcntl.h question.

  7. fcicq commented at 7:35 PM on May 30, 2013: contributor

    @jgarzik rebased.

  8. jgarzik commented at 7:45 PM on May 30, 2013: contributor

    Comments:

    • ACK current commits
    • Windows supports fcntl.h, so no need to guard with #ifdef. Just make sure that file includes fcntl.h [unless we're all missing some detail RE sys/fcntl.h].
    • Test plan: ideally, at a minimum an "it builds" test on our primary platforms (linux/win/osx)
  9. fcicq commented at 7:51 PM on May 30, 2013: contributor

    @jgarzik so just wait the pull tester :)

  10. BitcoinPullTester commented at 11:59 AM on June 2, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ef41705e7bd72c11c5f9ed34d24a5c3fbca8f1d7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  11. jgarzik commented at 3:24 PM on June 10, 2013: contributor

    ACK

  12. sipa commented at 7:20 PM on June 23, 2013: member

    I'd like confirmation that this doesn't break OSX builds, but ACK otherwise.

  13. luke-jr commented at 3:44 AM on July 17, 2013: member

    @fcicq Needs rebase again.

  14. Disable variadic template support in C++11 eb8397a03e
  15. Fix boost uint type bug by reordering the includes c391f9a47b
  16. Add missing constant for solaris 9371403993
  17. Ignore SIGPIPE signal on Solaris b34255b758
  18. Fix fcntl include in net.cpp & netbase.cpp 98148a713e
  19. BitcoinPullTester commented at 6:32 AM on July 20, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/98148a713e6e671f1d993ce4dc7aa4654b4beaff for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  20. jgarzik referenced this in commit 3d86e7cd48 on Aug 25, 2013
  21. jgarzik merged this on Aug 25, 2013
  22. jgarzik closed this on Aug 25, 2013

  23. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 09:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me