Hiding commands in the output of help based on user's current
configuration (the wallet is encrypted or not) can be confusing.
It doesn't seem to make sense to hide basic documentation from the
user in this way.
always show wallet encryption commands in `help` #2619
pull freewil wants to merge 1 commits into bitcoin:master from freewil:help-show-all-commands changing 1 files +4 −12-
freewil commented at 6:21 AM on May 5, 2013: contributor
-
06960f4394
always show wallet encryption commands in `help`
Hiding commands in the output of `help` based on user's current configuration (the wallet is encrypted or not) can be confusing. It doesn't seem to make sense to hide basic documentation from the user in this way.
-
luke-jr commented at 6:24 AM on May 5, 2013: member
Devil's advocate: whether a wallet is encrypted or not is not a state, but a nearly-fixed attribute of the wallet itself.
But I don't really care.
-
BitcoinPullTester commented at 7:14 AM on May 5, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/06960f43944aa986df43b8d71a1883686688593f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 1:47 PM on May 5, 2013: member
If you're doing this I think you should update the help messages to explicitly mention in what wallet states the commands can be used. Currently this is implicitly done by showing only appropriate commands.
-
-
jgarzik commented at 3:17 AM on August 25, 2013: contributor
Closing. Feel free to reopen, if feedback is addressed.
- jgarzik closed this on Aug 25, 2013
- DrahtBot locked this on Sep 8, 2021
Contributors