refactor: Make 64-bit shift explicit #26252

1. 
   hebasto commented at 7:14 pm on October 4, 2022: member

   std::array::at() expects an argument of the size_t type. This PR avoids implicit type conversion (for both 64-bit and 32-bit systems).

   Also it enables MSVC warning C4334 for all codebase.

2. 
   hebasto commented at 8:04 pm on October 4, 2022: member

   cc @sipa as an author of src/bech32.cpp (#11167).
3. 
   DrahtBot commented at 8:19 pm on October 4, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

4. DrahtBot added the label Refactoring on Oct 4, 2022
5. DrahtBot added the label Needs rebase on Oct 4, 2022
6. refactor: Make 64-bit shift explicit

   Also this change enables MSVC warning C4334 for all codebase.
   
   https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334

   5c5b85d0e7
7. hebasto force-pushed on Oct 4, 2022
8. DrahtBot removed the label Needs rebase on Oct 4, 2022
9. MarcoFalke approved
10. 
    MarcoFalke commented at 9:58 am on October 5, 2022: member

    ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745 🚎

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745 🚎
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUjVnAv9FQwGec5u0nG1WliXrLEgomK9sscEUIZ30DPpvI2ILk0Rzz/jhwd8mu30
     8rj+KOPnedU705XpjhB5BJ57eihBXYQBkCBN6cV0jMs3GsfwKgZqmNMCH9rdDgEWB
     9HxDi+4TW862m9svCZBDdx7V4atS7/VdRX5yA9v1IFaydqF6JFFgHGE1wm/oVH3sv
    10Kci50Lf+iRJxwBb1ejG8kHqbH5Q0SlPTfPChL4YmXC+yd2jfNF4DFzgMfrYfI822
    11lOjN5oyTiYWKeXBAVp6taEnlP/DyIuFvgozhoT27j578IwviivxSERL9RGAo3zPA
    12HrdGYZqx1F8CxQ1EhzbJltIQeWowRinlnJZ7ATPs0Glb0eUkWJtNZn+wRVvSkmb3
    13b9xWM73kT/5ilbHWEpJFNMNaVDJOWvWS+DJQkudr6zoS26go4u6bcUthKVFYOtvu
    14F0f2CTDkSqBm8lbNLOMIYTGFLfP4Kih26xYU2Edq4ope5jvU6ICLVGSL5Y09XzxV
    159y0qdut2
    16=/pMJ
    17-----END PGP SIGNATURE-----
    

11. 
    jonatack commented at 11:48 am on October 5, 2022: contributor

    Code review ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745
12. MarcoFalke merged this on Oct 5, 2022
13. MarcoFalke closed this on Oct 5, 2022

    ---

14. hebasto deleted the branch on Oct 5, 2022
15. sidhujag referenced this in commit a880052389 on Oct 5, 2022
16. bitcoin locked this on Oct 5, 2023

Contributors
hebasto DrahtBot MarcoFalke jonatack

Labels
Refactoring