setminrelayfee

amovfx commented at 0:02 am on October 6, 2022: none

I think this is something within my ability to add.

Is your feature request related to a problem? Please describe.

The ability to change minrelaytxfee without restarting.

Describe the solution you’d like

I would like the ability to set the relayfee by a bitcoin-cli rpc call.

 0setminrelayfee amount
 1
 2Set the transaction fee rate in BTC/kvB for this wallet. Overrides the global -setminrelayfee config parameter.
 3Can be deactivated by passing 0 as the fee. In that case automatic default min fee will be used.
 4
 5Arguments:
 61. amount    (numeric or string, required) The transaction fee rate in BTC/kvB
 7
 8Result:
 9true|false    (boolean) Returns true if successful
10
11Examples:
12> bitcoin-cli setminrelayfee 0.00001
13> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "setminrelayfee", "params": [0.00001]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/

Describe alternatives you’ve considered

Additional context

I encountered this while hooking up a lightning network node. My relay fee was too high from bad conf settings and was blocking funding transactions. I wasn’t able to change this value and had to restart bitcoind instead of just making an rpc call.

amovfx added the label Feature on Oct 6, 2022

amovfx renamed this:
~~setmin~~
setminrelayfee
on Oct 6, 2022

glozow commented at 10:14 am on October 6, 2022: member

This policy is already configurable using -minrelaytxfee.

kouloumos commented at 10:27 am on October 6, 2022: contributor

This policy is already configurable using -minrelaytxfee.

But can you change that without restarting? Not arguing about its necessity, but that’s what the feature request is about.

stickies-v commented at 10:29 am on October 6, 2022: contributor

Are there any real use cases for needing to change this value on-the-fly? If it’s just a matter of “I forgot to set this value when launching bitcoind”, then the appropriate solution would be to just restart bitcoind with the correct value and we shouldn’t be adding extra complexity to the RPC imo.

glozow commented at 10:35 am on October 6, 2022: member

I would generally concept NACK to making mempool policies dynamically configurable while the node is running, as

I haven’t heard any use case for this other than “I forgot to set it.”
You’d need to re-validate all your mempool transactions to adhere to this policy. Best way to do that is to restart for a dump/load.

maflcko added the label Brainstorming on Oct 6, 2022

maflcko added the label TX fees and policy on Oct 6, 2022

maflcko added the label Mempool on Oct 6, 2022

amovfx commented at 3:47 pm on October 6, 2022: none

The only use case I can really come up with is, “I forgot to set it” and “I set it wrong”. This is from my mistakes setting up an lnd node. I wanted to reach out to see if there was something I was missing like the re-validate mem-pool transactions so I don’t waste time going in a misguided direction. The end goal, was to maybe have lightning daemons able to make rpc calls to bitcoin to make sure funding transactions aren’t blocked by this flag.

2022-10-05 13:23:55.768 [ERR] FNDG: Unable to broadcast funding tx 02000000000102738b976fa9f90e9d17eb502a8910c8c7ebf13d3d9689b87dc50a7d213e000361010000000000000000bee9927a0f2de38a12a2e4eebb9f9960c4854edf6b2ffe6d77c43982a5054e8b01000000000000000002bf01010000000000225120747b824bea2fd1187c0672b2868fbca2360d29cc8cbc52f0a6bbd65974d1135fd001010000000000220020427018a0b91e19d8bd1c46dcdff990ceaa666da160d87938ca14508922fec03102483045022100c757022b0536d31d7fa9fae63814ae77262129b169f8f104585b55700fd01e5d0220221ffedf50ea71b631a6b164872c1c169e181547a516f9fc0576ee9003152360012103090346e5e46aa6a1398e3b2270708d3185def9c4787a3933eb7abadcaf1109920140b5249c7b622ad4b750b5cbf109ea67884a943306817813660cf95cb27f993fed37911452ae3be72f3a13e502a0f29badc53c00df70d2c937c49348d6cc5aa5a600000000 for ChannelPoint(26c6376140106de625a9cfe0398c1b0e58cd37dd8147d634d613e98a1624cf8e:1): unmatched backend error: -26: min relay fee not met, 444 < 2220

This feature would be a good learning exercise for me, but if the consensus is that it’s not a solid win for a software, let’s just close this? Thank you @glozow @stickies-v for insight on this. Maybe I’ll propose to lnd to check what the minrelaytxfee is on startup to throw a warning that bitcoin isn’t configured properly.

glozow commented at 4:48 pm on October 6, 2022: member

This feature would be a good learning exercise for me but if the consensus is that it’s not a solid win for a software, let’s just close this?

Thank you for your interest in contributing. I’d recommend issues/PRs labeled “good first issues” as they are usually conceptually non-controversial. PR review is both greatly needed on the repository and a fantastic way to learn the codebase. The contributing guide has more tips on getting started. Testing v24.0rc1 would also be greatly appreciated right now.

Maybe I’ll propose to lnd to check what the minrelaytxfee is on startup to throw a warning that bitcoin isn’t configured properly.

Seems appropriate to check that an assumption is true before proceeding.

glozow closed this on Oct 6, 2022

amovfx commented at 6:44 pm on October 6, 2022: none

ty!

bitcoin locked this on Oct 6, 2023

setminrelayfee #26269