Bugfix: Wallet: ResubmitWalletTransactions: Only bump m_next_resend if actually doing a relay #26270

Just the bugfix from #26205 (but reimplemented without refactoring)

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #26205 (wallet: #25768 follow ups by stickies-v)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

I'm not against a simple bugfix carve-out, but I think this is an incomplete fix because transactions can get rebroadcasted the first time ResubmitWalletTransactions is called with relay=True, as opposed to the expected behaviour where nothing will get rebroadcast in the first 12 hours.

I think you need to either default initialize m_next_resend (the approach taken in #26205, which is why I first introduced GetDefaultNextResend()) or re-introduce the fFirst flag that #25768 removed and update wallet_resendwallettransactions.py to re-introduce the node.mockscheduler(60) call that was removed.

Why not backport the whole #26205? This function was re-written from scratch anyway for 24.x/master, so doing another rewrite and keeping it the same for 24.x/master seems preferable than having two completely unrelated re-writes in each branch.

Ok, closing this then. If #26205 gets held up, I can reopen and address the initial send delay.