test: Prevent UB in minisketch_tests.cpp #26272

1. 
   hebasto commented at 11:52 am on October 6, 2022: member

   std::optional::operator*, which follows after the changed line, can cause UB.

   This PR addresses #26262 (comment)

2. test: Prevent UB in `minisketch_tests.cpp` 97007e2b9b
3. DrahtBot added the label Tests on Oct 6, 2022
4. stickies-v approved
5. 
   stickies-v commented at 1:52 pm on October 6, 2022: contributor

   ACK 97007e2b9b7a578315df2b1549cd6075130e8f05

   dec should never be dereferenced if has_value() is not true.

6. 
   maflcko commented at 2:00 pm on October 6, 2022: member

   BOOST_CHECK should still print the failure, making the UB more obvious, but this can’t hurt.

   LGTM

7. maflcko merged this on Oct 6, 2022
8. maflcko closed this on Oct 6, 2022

   ---

9. sidhujag referenced this in commit 7e057fbc1e on Oct 6, 2022
10. hebasto deleted the branch on Oct 6, 2022
11. bitcoin locked this on Oct 6, 2023

Contributors
hebasto stickies-v maflcko

Labels
Tests