test: Actually set sequence in MiniWallet create_self_transfer_multi #26278

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2210-test-seq-🕕 changing 1 files +1 −3
  1. maflcko commented at 12:41 PM on October 7, 2022: member

    Can be tested with:

    diff --git a/test/functional/test_framework/wallet.py b/test/functional/test_framework/wallet.py
    index de8eedc10e..25b630bb00 100644
    --- a/test/functional/test_framework/wallet.py
    +++ b/test/functional/test_framework/wallet.py
    @@ -284,6 +284,7 @@ class MiniWallet:
                 self._bulk_tx(tx, target_weight)
     
             txid = tx.rehash()
    +        assert [i.nSequence for i in tx.vin]==sequence
             return {
                 "new_utxos": [self._create_utxo(
                     txid=txid,
    
  2. test: Actually set sequence in MiniWallet create_self_transfer_multi fa547690ed
  3. DrahtBot added the label Tests on Oct 7, 2022
  4. kouloumos commented at 1:27 PM on October 28, 2022: contributor

    Not such a big of an issue (as I believe other tests would break if that was the case) but this test scenario is not tested since #25522 where this was introduced.

    I believe that the current logic of how create_self_transfer_multi uses create_self_transfer in order to create a simple transaction template to then adjust (copy and adapt) based on its arguments can more easily lead to this kind of issues and is more of a maintenance burden.

    Looking into this, I've came up with a change in logic, where create_self_transfer uses create_self_transfer_multi. I think this simplifies the code and (if I am not missing something) could be a replacement to this PR. You can see this change in https://github.com/kouloumos/bitcoin/commit/0b78110f73965fd827748107e0f3497d3352be71 (modify-create_self_transfer branch).

  5. maflcko commented at 1:35 PM on October 28, 2022: member

    Sounds good

  6. maflcko closed this on Oct 28, 2022

  7. maflcko deleted the branch on Oct 28, 2022
  8. maflcko referenced this in commit 38cbf43dee on Dec 5, 2022
  9. sidhujag referenced this in commit 59b077f4e5 on Dec 5, 2022
  10. bitcoin locked this on Oct 28, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me