wallet: have prune error take precedence over assumedvalid #26282

1. 
   jamesob commented at 7:18 pm on October 7, 2022: member

   Fixes #23997 (review).

   From Russ Yanofsky:

   Agree with all of Marco’s points here and think this should be updated

   If havePrune and hasAssumedValidChain are both true, better to show havePrune error message. Assumed-valid error message is vague and not very actionable. Would suggest “Error loading wallet. Wallet requires blocks to be downloaded, and software does not currently support loading wallets while blocks are being downloaded out of order though assumeutxo snapshots. Wallet should be able to load successfully after node sync reaches height {block_height}”

2. wallet: have prune error take precedence over assumedvalid

   From Russ Yanofsky:
   
   "Agree with all of Marco's points here and think this should be updated
   
   If havePrune and hasAssumedValidChain are both true, better to show
   havePrune error message.  Assumed-valid error message is vague and not
   very actionable.  Would suggest "Error loading wallet. Wallet requires
   blocks to be downloaded, and software does not currently support loading
   wallets while blocks are being downloaded out of order though assumeutxo
   snapshots. Wallet should be able to load successfully after node sync
   reaches height {block_height}"
   
   Co-authored-by: MacroFake <MarcoFalke@gmail.com>
   Co-authored-by: Russ Yanofsky <russ@yanofsky.org>

   1c36bafc5f
3. jamesob force-pushed on Oct 7, 2022
4. DrahtBot added the label Wallet on Oct 7, 2022
5. 
   maflcko commented at 7:47 am on October 10, 2022: member

   ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0
6. aureleoules approved
7. 
   aureleoules commented at 8:02 am on October 10, 2022: member

   ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0
8. fanquake merged this on Oct 10, 2022
9. fanquake closed this on Oct 10, 2022

   ---

10. sidhujag referenced this in commit 0ca55f8355 on Oct 10, 2022
11. bitcoin locked this on Oct 10, 2023

Contributors
jamesob maflcko aureleoules

Labels
Wallet