test: Make system_tests/run_command test locale and platform agnostic #26377

1. 
   hebasto commented at 12:53 pm on October 24, 2022: member

   Fixes bitcoin/bitcoin#26368.
2. test: Make `system_tests/run_command` locale agnostic 884304e6c6
3. hebasto added the label Tests on Oct 24, 2022
4. maflcko added this to the milestone 24.0 on Oct 24, 2022
5. maflcko added the label Needs backport (23.x) on Oct 24, 2022
6. maflcko added the label Needs backport (24.x) on Oct 24, 2022
7. maflcko removed the label Needs backport (23.x) on Oct 24, 2022
8. maflcko removed the label Needs backport (24.x) on Oct 24, 2022
9. maflcko removed this from the milestone 24.0 on Oct 24, 2022
10. 
    hebasto commented at 1:27 pm on October 24, 2022: member

    #26368 (comment):

    Can confirm this fixes the problem for me.

11. 
    DrahtBot commented at 10:25 pm on October 24, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25696 (build: Re-enable external signer on Windows by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. 
    Sjors commented at 1:41 pm on October 26, 2022: member

    Concept ACK

    Not sure how to test this for cross compilation without #25696 (which conflict with this commit), since the test needs ENABLE_EXTERNAL_SIGNER to be defined. But can test the native build.

13. 
    Sjors commented at 3:00 pm on October 26, 2022: member

    tACK 884304e6c6a250719a64752fe52d1283cd5e36ab

    Tested with native build: .\src\test_bitcoin.exe --run_test=system_tests

14. maflcko merged this on Oct 28, 2022
15. maflcko closed this on Oct 28, 2022

    ---

16. hebasto deleted the branch on Oct 28, 2022
17. sidhujag referenced this in commit f8c56dc55d on Oct 28, 2022
18. bitcoin locked this on Oct 28, 2023

Contributors
hebasto DrahtBot Sjors

Labels
Tests