Revert “test: check importing wallets when blocks are pruned throw an error” #26380

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2210-test-revert-📒 changing 1 files +0 −2
  1. maflcko commented at 1:29 pm on October 24, 2022: member

    The test doesn’t pass (not detected by the normal CI, because it is an extended test):

     0Traceback (most recent call last):
     1  File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/test_framework.py", line 133, in main
     2    self.run_test()
     3  File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/feature_pruning.py", line 480, in run_test
     4    self.wallet_test()
     5  File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/feature_pruning.py", line 361, in wallet_test
     6    assert_raises_rpc_error(-4, "Importing wallets is disabled when blocks are pruned", self.nodes[2].importwallet, "abc")
     7  File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/util.py", line 130, in assert_raises_rpc_error
     8    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
     9  File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/util.py", line 145, in try_rpc
    10    raise AssertionError(
    11AssertionError: Expected substring not found in error message:
    12substring: 'Importing wallets is disabled when blocks are pruned'
    13error message: 'Only legacy wallets are supported by this command'.
    

    So revert it for now, which will be done anyway in https://github.com/bitcoin/bitcoin/pull/24865/commits. (This commit is taken from there)

  2. Revert "test: check importing wallets when blocks are pruned throw an error"
    This reverts commit 4aff7a48a4e0f1075306f181a276b8a74c857022.
    e1eadaa72d
  3. andrewtoth commented at 1:47 pm on October 24, 2022: contributor
    ACK e1eadaa72d6831d1d0a53ba97c215dc4cdb64436
  4. maflcko merged this on Oct 24, 2022
  5. maflcko closed this on Oct 24, 2022

  6. maflcko deleted the branch on Oct 24, 2022
  7. sidhujag referenced this in commit b6b7c1bb01 on Oct 25, 2022
  8. bitcoin locked this on Oct 24, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me