test: fix intermittent failure in feature_index_prune.py #26417

pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202210_testfix_indexprune changing 1 files +1 −0

mzumsande commented at 8:08 PM on October 28, 2022: contributor
I can't reproduce the error from #26630 locally, but from analying the logs I think the problem is the following:

After calling sync_blocks, we didn't check that the indexes have caught up to the tip before performing the manual pruning. This could possibly lead to prune blockers with a lower height than the expected 2489, which do appear in the logs of the failed CI runs, e.g.
- 2022-10-27T21:14:17.703920Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\validation.cpp:2395] [FlushStateToDisk] [prune] coinstatsindex limited pruning to height 2488 (Cirrus)
So, this should be fixed by a call to sync_index. Fixes #26330

test: fix intermittent failure in feature_index_prune.py

After syncing the blocks, we didn't check that the
indexes have caught up to the tip before manually pruning.
This could lead to prune blockers lower thatn the expected height.

201b9a02fd

fanquake added the label Tests on Oct 28, 2022
brunoerg approved
brunoerg commented at 1:51 PM on November 2, 2022: contributor

crACK 201b9a02fd9885ce40999e383cf75b8354d6ef26

I wasn't able to reproduce it locally but waiting for the indexes have caught up to the tip should fix it. It seems a little bit similar to #26098 and #26143.
maflcko merged this on Nov 2, 2022
maflcko closed this on Nov 2, 2022
mzumsande deleted the branch on Nov 3, 2022
sidhujag referenced this in commit 8ebf8cebe3 on Nov 3, 2022
bitcoin locked this on Nov 3, 2023

Contributors

mzumsande

brunoerg

Labels

Tests

Linked (view graph)

#26330 test: Intermittent failure in `feature_index_prune.py`#26630 test: Fix intermittent issue in rpc_net.py