WIP: Fix coinstatsindex overflow issue #26426

1. 
   fjahr commented at 0:01 am on October 31, 2022: contributor

   Closes #26362

   This changes cumulative values in coinstatsindex to be per-block instead. This is still work in progress and needs further testing and cleanup. Please refer to #26362 for conceptual discussion for now.

2. wip: fix coinstatsindex overflow issue 3346437a41
3. 
   DrahtBot commented at 7:19 am on October 31, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28685 (coinstats, assumeutxo: fix hash_serialized2 calculation by fjahr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. fanquake added the label UTXO Db and Indexes on Oct 31, 2022
5. in src/rpc/blockchain.cpp:880 in 3346437a41

   876@@ -877,7 +877,7 @@ static RPCHelpMan gettxoutsetinfo()
   877                         {RPCResult::Type::NUM, "transactions", /*optional=*/true, "The number of transactions with unspent outputs (not available when coinstatsindex is used)"},
   878                         {RPCResult::Type::NUM, "disk_size", /*optional=*/true, "The estimated size of the chainstate on disk (not available when coinstatsindex is used)"},
   879                         {RPCResult::Type::STR_AMOUNT, "total_amount", "The total amount of coins in the UTXO set"},
   880-                        {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The total amount of coins permanently excluded from the UTXO set (only available if coinstatsindex is used)"},
   881+                        {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The amount of coins permanently excluded from the UTXO set from this block onwards (only available if coinstatsindex is used)"},
   

   ---

   ---

   

   luke-jr commented at 7:19 pm on November 5, 2022:

   “onwards” seems unlikely to be correct?

   ---

   

   luke-jr commented at 7:25 pm on November 5, 2022:

   Should rename the field if it’s a different value
6. luke-jr changes_requested
7. DrahtBot added the label Needs rebase on Oct 23, 2023
8. 
   DrahtBot commented at 7:22 pm on October 23, 2023: contributor

   🐙 This pull request conflicts with the target branch and needs rebase.

9. 
   DrahtBot commented at 10:44 am on January 5, 2024: contributor

   There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

   • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
   • Is it no longer relevant? ➡️ Please close.
   • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
10. 
    DrahtBot commented at 1:51 am on April 3, 2024: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
11. 
    DrahtBot commented at 1:37 am on July 1, 2024: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
12. 
    maflcko commented at 5:51 am on July 1, 2024: member

    Closing for now due to inactivity for 1.5 years. #https://github.com/bitcoin/bitcoin/issues/26362 remains open and can be used for discussion. This change can be reopened or recreated as a new pull request.
13. maflcko closed this on Jul 1, 2024

    ---

14. 
    fjahr commented at 10:46 am on July 17, 2024: contributor

    #30469 continues the work here

Contributors
fjahr DrahtBot luke-jr maflcko

Labels
UTXO Db and Indexes Needs rebase