WIP: Fix coinstatsindex overflow issue #26426

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:202210-coinstatsindex-overflow changing 4 files +46 −69

fjahr commented at 12:01 AM on October 31, 2022: contributor

Closes #26362

This changes cumulative values in coinstatsindex to be per-block instead. This is still work in progress and needs further testing and cleanup. Please refer to #26362 for conceptual discussion for now.
wip: fix coinstatsindex overflow issue 3346437a41
DrahtBot commented at 7:19 AM on October 31, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #28685 (coinstats, assumeutxo: fix hash_serialized2 calculation by fjahr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label UTXO Db and Indexes on Oct 31, 2022

in src/rpc/blockchain.cpp:880 in 3346437a41

 876 | @@ -877,7 +877,7 @@ static RPCHelpMan gettxoutsetinfo()
 877 |                          {RPCResult::Type::NUM, "transactions", /*optional=*/true, "The number of transactions with unspent outputs (not available when coinstatsindex is used)"},
 878 |                          {RPCResult::Type::NUM, "disk_size", /*optional=*/true, "The estimated size of the chainstate on disk (not available when coinstatsindex is used)"},
 879 |                          {RPCResult::Type::STR_AMOUNT, "total_amount", "The total amount of coins in the UTXO set"},
 880 | -                        {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The total amount of coins permanently excluded from the UTXO set (only available if coinstatsindex is used)"},
 881 | +                        {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The amount of coins permanently excluded from the UTXO set from this block onwards (only available if coinstatsindex is used)"},

luke-jr commented at 7:19 PM on November 5, 2022:

"onwards" seems unlikely to be correct?

luke-jr commented at 7:25 PM on November 5, 2022:

Should rename the field if it's a different value

luke-jr changes_requested
DrahtBot added the label Needs rebase on Oct 23, 2023
DrahtBot commented at 7:22 PM on October 23, 2023: contributor



🐙 This pull request conflicts with the target branch and needs rebase.
DrahtBot commented at 10:44 AM on January 5, 2024: contributor


There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
DrahtBot commented at 1:51 AM on April 3, 2024: contributor


⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
DrahtBot commented at 1:37 AM on July 1, 2024: contributor


⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
maflcko commented at 5:51 AM on July 1, 2024: member

Closing for now due to inactivity for 1.5 years. #https://github.com/bitcoin/bitcoin/issues/26362 remains open and can be used for discussion. This change can be reopened or recreated as a new pull request.
maflcko closed this on Jul 1, 2024
fjahr commented at 10:46 AM on July 17, 2024: contributor

#30469 continues the work here
bitcoin locked this on Jul 18, 2025

Contributors

Labels

UTXO Db and Indexes Needs rebase

Linked (view graph)

#26362 signed overflow in coinstats index #30469 index: Fix coinstats overflow

WIP: Fix coinstatsindex overflow issue #26426

Conflicts