Update BnB upper bound to use min_viable_change #26466

issue S3RK openend this issue on November 7, 2022
  1. S3RK commented at 8:13 am on November 7, 2022: contributor

    Context: SelectCoinsBnB uses cost_of_change as the upper bound for the search of changeless solution. However when building a tx the actual range for dropping change is determined by min_viable_change and change_fee (see SelectionResult::GetChange).

    0min_viable_change = std::max(change_spend_fee + 1, dust);
    1cost_of_change = change_spend_fee + change_fee;
    

    That means that BnB forgoes some of the changeless solutions in cases when dust threshold is higher than change_spend_fee.

    Proposal: Update BnB upper bound to be consistent with tx building, i.e. it should use exactly the same threshold for when the change is viable.

  2. S3RK added the label Feature on Nov 7, 2022
  3. achow101 added the label Wallet on Nov 9, 2022
  4. remyers referenced this in commit 7df63761eb on Sep 16, 2024
  5. murchandamus commented at 9:46 pm on February 12, 2025: contributor
    That’s a great idea!

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-23 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me