This small PR adds missing "bech32m" address type / BIP86 checks w.r.t. to the getnewaddress/getrawchangeaddress RPC and descriptor export functionality to the functional test wallet_descriptor.py.
test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py #26472
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202211-test-add_missing_bech32m_bip86_tests_to_wallet_descriptor_py changing 1 files +13 −1-
theStack commented at 5:51 PM on November 8, 2022: contributor
-
test: add missing bech32m / BIP86 test-cases to wallet_descriptor.py 887d85e43d
- fanquake added the label Tests on Nov 8, 2022
- shaavan approved
-
shaavan commented at 2:04 PM on November 9, 2022: contributor
ACK 887d85e43d136dbfc2428f873ced3de50076bbd0
- The added code covers the
bech32mcode completely. - The test ran flawlessly, without any issues.
- The added code covers the
- kristapsk approved
-
kristapsk commented at 2:16 PM on November 9, 2022: contributor
ACK 887d85e43d136dbfc2428f873ced3de50076bbd0
- maflcko merged this on Nov 9, 2022
- maflcko closed this on Nov 9, 2022
- theStack deleted the branch on Nov 9, 2022
- sidhujag referenced this in commit a50f834557 on Nov 9, 2022
-
DrahtBot commented at 3:53 PM on November 9, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26076 (Switch hardened derivation marker to h (in normalized descriptors and new wallets) by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- bitcoin locked this on Nov 9, 2023
