test: Split overly large util_tests.cpp file #26489

1. 
   maflcko commented at 11:02 am on November 11, 2022: member

   The file has ~3kLOC and is slow to compile.

   Fix both issues by splitting it. (On my machine the compilation goes from 25 seconds previously to 17+10 seconds for the two smaller files)

   To review, --color-moved=dimmed-zebra can be used.

2. DrahtBot added the label Tests on Nov 11, 2022
3. 
   DrahtBot commented at 11:37 pm on November 11, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #26213 (univalue: Remove confusing getBool/isTrue/isFalse by MarcoFalke)
   • #26028 (More verbose warning for multiple network argument error. by amovfx)
   • #17783 (util: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior by ryanofsky)
   • #17581 (refactor: Remove settings merge reverse precedence code by ryanofsky)
   • #17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)
   • #17493 (util: Forbid ambiguous multiple assignments in config file by ryanofsky)
   • #16545 (refactor: Implement missing error checking for ArgsManager flags by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. in src/test/argsman_tests.cpp:17 in fae2420f16 outdated

   12+#include <univalue.h>
   13+
   14+#include <array>
   15+#include <optional>
   16+#include <cstdint>
   17+#include <cstring>
   

   ---

   ---

   

   shaavan commented at 8:05 am on November 12, 2022:

   nit: These dependencies can be removed

   ---

   

   maflcko commented at 8:14 am on November 12, 2022:

   No, they are needed, see https://en.cppreference.com/w/cpp/types/integer

   ---

   

   shaavan commented at 1:34 pm on November 14, 2022:

   Okay, I verified that two dependencies are indeed needed for the file.

   ---

   

   maflcko commented at 1:37 pm on November 14, 2022:

   I hope we can use iwyu one day on the tests :sweat_smile:

   ---

   

   shaavan commented at 1:40 pm on November 14, 2022:

   Thanks a lot for the name. I was searching for this tool, but I forgot its name. I will remember to use it from now on. 😄
5. 
   shaavan commented at 8:11 am on November 12, 2022: contributor

   Concept ACK

   I successfully compiled the branch and ran the test on it.

   I think some dependencies would be redundant and can be removed.

   in src/test/util_tests.cpp

   0#include <test/util/logging.h>
   1#include <test/util/str.h>
   

   and, in src/test/argsman_tests.cpp

6. test: Split overly large util_tests.cpp file fa4ec1be51
7. maflcko force-pushed on Nov 14, 2022
8. shaavan approved
9. 
   shaavan commented at 1:37 pm on November 14, 2022: contributor

   ACK fa4ec1be513c80d6db644f1e3170e980035e7306

   • The redundant dependencies are removed from the src/test/util_tests.cpp file.
10. in src/test/argsman_tests.cpp:5 in fa4ec1be51

    0@@ -0,0 +1,1043 @@
    1+// Copyright (c) 2011-2022 The Bitcoin Core developers
    2+// Distributed under the MIT software license, see the accompanying
    3+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
    4+
    5+#include <util/system.h>
    

    ---

    ---

    

    aureleoules commented at 2:42 pm on November 15, 2022:

    nit

     0diff --git a/src/test/argsman_tests.cpp b/src/test/argsman_tests.cpp
     1index d00876bc7..76d64e0d5 100644
     2--- a/src/test/argsman_tests.cpp
     3+++ b/src/test/argsman_tests.cpp
     4@@ -2,13 +2,13 @@
     5 // Distributed under the MIT software license, see the accompanying
     6 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
     7 
     8-#include <util/system.h>
     9 #include <fs.h>
    10 #include <sync.h>
    11 #include <test/util/logging.h>
    12 #include <test/util/setup_common.h>
    13 #include <test/util/str.h>
    14 #include <util/strencodings.h>
    15+#include <util/system.h>
    16 #include <univalue.h>
    17 
    18 #include <array>
    

11. aureleoules approved
12. 
    aureleoules commented at 2:43 pm on November 15, 2022: member

    ACK fa4ec1be513c80d6db644f1e3170e980035e7306
13. 
    RandyMcMillan commented at 4:25 pm on November 15, 2022: contributor

    ACK fa4ec1be513c80d6db644f1e3170e980035e7306 for:

    macOS x84_64: Darwin ₿ 19.6.0 Darwin Kernel Version 19.6.0: Tue Jun 21 21:18:39 PDT 2022; root:xnu-6153.141.66~1/RELEASE_X86_64 x86_64

    macOS Arm64: Darwin DeepSpaceM1.local 21.6.0 Darwin Kernel Version 21.6.0: Thu Sep 29 20:13:46 PDT 2022; root:xnu-8020.240.7~1/RELEASE_ARM64_T8101 arm64

14. maflcko merged this on Nov 15, 2022
15. maflcko closed this on Nov 15, 2022

    ---

16. maflcko deleted the branch on Nov 15, 2022
17. sidhujag referenced this in commit 068335a15c on Nov 16, 2022
18. bitcoin locked this on Nov 15, 2023

Contributors
maflcko DrahtBot shaavan aureleoules RandyMcMillan

Labels
Tests