Use descriptor wallets by default in functional tests #26511

1. 
   S3RK commented at 7:55 am on November 16, 2022: contributor

   Since 23.0 descriptor wallet is the default wallet type. As part of the transition it also make sense to make it default wallet type for functional tests
2. S3RK added the label Feature on Nov 16, 2022
3. maflcko added the label Tests on Nov 16, 2022
4. maflcko removed the label Feature on Nov 16, 2022
5. 
   maflcko commented at 8:01 am on November 16, 2022: member

   This is a two-line patch, no? Seems easier to just create the pull instead of an issue?
6. 
   kouloumos commented at 8:18 am on November 16, 2022: contributor

   Default wallet type (if no --descriptors or --legacy-wallet flag is provided) is determined here https://github.com/bitcoin/bitcoin/blob/f0c646f026e652082e798800136dc06c734fdab6/test/functional/test_framework/test_framework.py#L215-L220

   The suggestion is to prefer sqlite instead of the currently preferred BDB. Makes sense.

   Minor correction, I believe that descriptors are the default since 23.0

7. 
   S3RK commented at 8:19 am on November 16, 2022: contributor

   This is a two-line patch, no? Seems easier to just create the pull instead of an issue?

   Sorry, I was on mobile. Also wasn’t sure 1) when is a good time to do the change 2) whether any tests will break.

   If it’s that simple can mark it with “good first issue” also

8. achow101 closed this on Dec 20, 2022

   ---

9. sidhujag referenced this in commit 8e3fb5a930 on Dec 21, 2022
10. bitcoin locked this on Dec 20, 2023

Contributors
S3RK maflcko kouloumos

Labels
Tests