test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. #26517

pull Randy808 wants to merge 1 commits into bitcoin:master from Randy808:use-vsize-for-fee-tests changing 1 files +3 −3

Randy808 commented at 5:44 AM on November 17, 2022: contributor

The fee rates used in feature_fee_estimation.py are calculated using the raw transaction size instead of the virtual transaction size (which is used in 'CBlockPolicyEstimator::processBlockTx' and 'CBlockPolicyEstimator::processBlock'). This leads to inconsistencies as the fee rates used in check_raw_estimates are incorrect and can cause assertions to fail.

refs #25179
test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. 6fb102c9f3
DrahtBot added the label Tests on Nov 17, 2022
theStack commented at 12:19 PM on November 17, 2022: contributor

Concept ACK
maflcko commented at 4:32 PM on December 7, 2022: member

ACK 6fb102c9f361a7ba0a6aa0a9b41315f5e04559f7
DrahtBot commented at 4:32 PM on December 7, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke

Concept ACK theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko merged this on Dec 7, 2022
maflcko closed this on Dec 7, 2022
sidhujag referenced this in commit 9bbf6c7c1b on Dec 8, 2022
bitcoin locked this on Dec 7, 2023

Type	Reviewers
ACK	MarcoFalke
Concept ACK	theStack

Contributors

Labels

Linked (view graph)

#25179 "Estimated fee out of range" intermittent failure in feature_fee_estimation.py

test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. #26517

Reviews