test: small fixups/improvements for get_previous_releases.py #26589

1. 
   theStack commented at 12:03 pm on November 28, 2022: contributor

   This is a small follow-up to #25650 (commit 614d4682badaadac74b825a45aaee9c2309a3e81) with three fixes/improvements:

   • fix “Checksum did not match” detection, which was not adapted to the new SHA256_SUMS structure and hence never executed (the list of tarball names isn’t directly in the dictionary’s values anymore, but has to be extracted from the 'tarball' field of each value)
   • make both help text and default tag download order deterministic by sorting default tags
   • --tags argument help text: add missing space between “for” and “backwards”
2. script: small fixups/improvements for get_previous_releases.py

   This is a small follow-up to #25650 (commit
   614d4682badaadac74b825a45aaee9c2309a3e81) with three fixes/improvements:
   
   - fix "Checksum did not match" detection, which was not adapted to the new
     SHA256_SUMS structure and hence never executed (the list of tarball
     names isn't directly in the dictionary's values anymore, but has to be
     extracted from the 'tarball' field of each value)
   - make both help text and default tag download order deterministic by
     sorting default tags
   - "--tags" argument help text: add missing space between "for" and
     "backwards"

   9b5feb76bc
3. 
   DrahtBot commented at 12:03 pm on November 28, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Sjors, josibake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Consensus on Nov 28, 2022
5. fanquake removed the label Consensus on Nov 28, 2022
6. fanquake added the label Tests on Nov 28, 2022
7. fanquake requested review from josibake on Nov 28, 2022
8. fanquake requested review from Sjors on Nov 28, 2022
9. maflcko renamed this:
   script: small fixups/improvements for get_previous_releases.py
   test: small fixups/improvements for get_previous_releases.py
   on Nov 28, 2022
10. maflcko removed the label Tests on Nov 28, 2022
11. DrahtBot added the label Tests on Nov 28, 2022
12. Sjors approved
13. 
    Sjors commented at 12:54 pm on November 28, 2022: member

    tACK 9b5feb76bc9458eec806db677af6161b56b8b23f. Tested that if I change a checksum, or remove a release, it catches that.
14. josibake approved
15. 
    josibake commented at 12:55 pm on November 28, 2022: member

    tested ACK https://github.com/bitcoin/bitcoin/pull/26589/commits/9b5feb76bc9458eec806db677af6161b56b8b23f

    I modified the sha256 sum for v23 and then ran ./test/get_previous_releseases.py -b v23.0 to verify I got the expected error of “Checksum did not match.”

    This could be addressed in a follow-up, but I did notice while testing that if the binaries have been previously downloaded the script will use the cached version and skip checking the sha256sum. Seems like it would be better to still check the sha256sum even if using the cached binary as the binary could have been corrupted/modified since it was previously downloaded.

    EDIT: regarding cached binaries, we delete the tarball after we check it and it doesn’t seem worth it to keep the tarball around just so that we can re-verify the checksum and unzip it every time we want to use it, so nvm

16. maflcko merged this on Nov 28, 2022
17. maflcko closed this on Nov 28, 2022

    ---

18. theStack deleted the branch on Nov 28, 2022
19. sidhujag referenced this in commit a807bc429f on Dec 1, 2022
20. bitcoin locked this on Nov 28, 2023

Contributors
theStack DrahtBot Sjors josibake

Labels
Tests