Both nodes must be aware of the closed connections before re-connecting, otherwise the test will fail.
Fixes #25741
test: Fix intermittent issue in rpc_net.py #26630
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2212-test-net-int-💆 changing 1 files +2 −1-
maflcko commented at 4:45 PM on December 3, 2022: member
-
test: Fix intermittent issue in rpc_net.py fadf7b8fef
-
DrahtBot commented at 4:45 PM on December 3, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK jarolrod If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Dec 3, 2022
-
jarolrod commented at 4:38 AM on December 4, 2022: member
ACK fadf7b8fef5ef7111e4634137f8b961b21217cdb
CI is happy. As the comment states, we want to wait for all sockets to close but we only check this within one of the nodes, this change is correct.
- fanquake merged this on Dec 4, 2022
- fanquake closed this on Dec 4, 2022
- maflcko deleted the branch on Dec 4, 2022
- vertiond referenced this in commit 5274f32437 on Dec 4, 2022
- sidhujag referenced this in commit f1d2144c45 on Dec 5, 2022
- sidhujag referenced this in commit 8ebf8cebe3 on Mar 25, 2023
- bitcoin locked this on Dec 4, 2023
