test: Run mempool_compatibility.py with MiniWallet #26640

1. 
   maflcko commented at 11:17 am on December 5, 2022: member

   By using the already existing miniwallet, the test can be run even when no wallet is compiled.
2. 
   DrahtBot commented at 11:17 am on December 5, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Dec 5, 2022
4. fanquake requested review from glozow on Dec 5, 2022
5. test: Run mempool_compatibility.py with MiniWallet fa43f60a0c
6. maflcko force-pushed on Dec 5, 2022
7. 
   maflcko commented at 12:14 pm on December 5, 2022: member

   It doesn’t matter if the txs are descendants/ancestors of each other, so I just did that to make the diff even smaller.
8. 
   glozow commented at 1:46 pm on December 5, 2022: member

   ACK fa43f60a0c24880bf4802c74890644ae785bec7d

   • AFAICT code in test does effectively the same thing as before
   • test still runs when I disable wallet
   • test still passes normally, fails if I delete certain line of LoadMempool or DumpMempool
9. 
   achow101 commented at 5:37 pm on December 5, 2022: member

   ACK fa43f60a0c24880bf4802c74890644ae785bec7d
10. achow101 merged this on Dec 5, 2022
11. achow101 closed this on Dec 5, 2022

    ---

12. maflcko deleted the branch on Dec 6, 2022
13. bitcoin locked this on Dec 6, 2023

Contributors
maflcko DrahtBot glozow achow101

Review Requested
glozow

Labels
Tests