test: Wallet interactions with rescanning wallet #26700

pull aureleoules wants to merge 1 commits into bitcoin:master from aureleoules:2022-12-rescan-tests changing 2 files +34 −3

aureleoules commented at 5:28 pm on December 14, 2022: member

This pull request tests that interacting with a wallet while rescanning will fail with Wallet is currently rescanning. Abort existing rescan or wait..

I’m running a rescan for each RPC command being tested instead of only one for all to avoid intermittent failures. Each rescan takes about 2 seconds, enough time to run the tested RPC commands simultaneously. I added this test in feature_pruning.py to use the large chain generated and renamed it to feature_large_chain.py as I think it is more appropriate now.
DrahtBot commented at 5:28 pm on December 14, 2022: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

No conflicts as of last run.
DrahtBot added the label RPC/REST/ZMQ on Dec 14, 2022
aureleoules renamed this:
~~rpc: Prevent unloading a wallet when rescanning~~
test: Wallet interactions with rescanning wallet
on Dec 14, 2022
DrahtBot added the label Needs rebase on Dec 16, 2022
maflcko removed the label RPC/REST/ZMQ on Dec 17, 2022
aureleoules force-pushed on Jan 10, 2023
aureleoules marked this as ready for review on Jan 10, 2023
DrahtBot removed the label Needs rebase on Jan 10, 2023
DrahtBot added the label Tests on Jan 10, 2023
DrahtBot added the label Needs rebase on Jan 16, 2023
aureleoules force-pushed on Jan 18, 2023
test: Wallet interactions on rescanning wallet d77d3a767a
aureleoules force-pushed on Jan 18, 2023
DrahtBot removed the label Needs rebase on Jan 18, 2023
aureleoules commented at 12:27 pm on January 25, 2023: member

This PR seems to generate intermittent failures despite my efforts…
aureleoules marked this as a draft on Jan 25, 2023
DrahtBot added the label Needs rebase on Feb 22, 2023
DrahtBot commented at 8:56 pm on February 22, 2023: contributor

🐙 This pull request conflicts with the target branch and needs rebase.
DrahtBot commented at 1:16 am on May 23, 2023: contributor
There hasn’t been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.

in test/functional/feature_large_chain.py:387 in d77d3a767a

382+        for command in commands:
383+            t = threading.Thread(target=wallet.rescanblockchain)
384+            t.daemon = True
385+            t.start()
386+
387+            assert_raises_rpc_error(-4, "Wallet is currently rescanning. Abort existing rescan or wait.", self.nodes[0].cli(*command).send_cli)

maflcko commented at 6:06 am on May 23, 2023:

This will race against the thread t, which may have already concluded before this point

DrahtBot commented at 0:49 am on August 21, 2023: contributor
There hasn’t been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
maflcko closed this on Aug 21, 2023
maflcko commented at 8:22 am on August 21, 2023: member

A new pull can be opened, once and if this is rebased, and the tests pass.
bitcoin locked this on Aug 20, 2024

Contributors
aureleoules DrahtBot maflcko

Labels
Tests Needs rebase

test: Wallet interactions with rescanning wallet #26700

Reviews

Conflicts