contrib: make DNS seeds file an argument in CLI (makeseeds) #26701

1. 
   brunoerg commented at 6:58 pm on December 14, 2022: contributor

   Instead of using makeseeds.py this way:

   0python3 makeseeds.py -a asmap-filled.dat < seeds_main.txt > nodes_main.txt
   

   We could use the DNS seeds file as an argument since it is a required one. It improves the way the script handles it when that file is missing as well as makes this script more friendly. E.g:

   0python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt
   

2. 
   DrahtBot commented at 6:58 pm on December 14, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	vincenzopalazzo

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Scripts and tools on Dec 14, 2022
4. brunoerg force-pushed on Dec 14, 2022
5. vincenzopalazzo approved
6. 
   vincenzopalazzo commented at 9:11 pm on December 17, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/26701/commits/fdb3bd5e2f268cd02dee372302b10fcc411196a8
7. 
   maflcko commented at 8:47 am on December 19, 2022: member

   In theory the arg could be optional and fallback to stdin, but not sure if it is worth it. In either case, the commits should be squashed.
8. contrib: make DNS seeds file an argument in CLI 1c07500dbb
9. 
   brunoerg commented at 10:20 am on December 19, 2022: contributor

   Force-pushed squashing the commits. Thanks, @MarcoFalke
10. brunoerg force-pushed on Dec 19, 2022
11. fanquake requested review from vincenzopalazzo on Feb 6, 2023
12. vincenzopalazzo approved
13. 
    vincenzopalazzo commented at 8:43 am on February 7, 2023: none

    ACK https://github.com/bitcoin/bitcoin/pull/26701/commits/1c07500dbb6b93510425c8bbdb320f2533efdb3d
14. maflcko merged this on Feb 7, 2023
15. maflcko closed this on Feb 7, 2023

    ---

16. sidhujag referenced this in commit ef616db513 on Feb 7, 2023
17. bitcoin locked this on Feb 7, 2024

Contributors
brunoerg DrahtBot vincenzopalazzo maflcko

Labels
Scripts and tools