refactor: Fix performance-for-range-copy in headers #26710

1. 
   hebasto commented at 10:55 am on December 16, 2022: member

   Split from bitcoin/bitcoin#26705 as was requested in #26705 (comment).

   To test this PR, consider applying a diff as follows:

    0--- a/src/.clang-tidy
    1+++ b/src/.clang-tidy
    2@@ -12,17 +12,9 @@ readability-redundant-declaration,
    3 readability-redundant-string-init,
    4 '
    5 WarningsAsErrors: '
    6-bugprone-argument-comment,
    7-bugprone-use-after-move,
    8-misc-unused-using-decls,
    9-modernize-use-default-member-init,
   10-modernize-use-nullptr,
   11 performance-for-range-copy,
   12-performance-move-const-arg,
   13-performance-unnecessary-copy-initialization,
   14-readability-redundant-declaration,
   15-readability-redundant-string-init,
   16 '
   17 CheckOptions:
   18  - key: performance-move-const-arg.CheckTriviallyCopyableMove
   19    value: false
   20+HeaderFilterRegex: '.'
   

2. clang-tidy: Fix `performance-for-range-copy` in headers

   See https://clang.llvm.org/extra/clang-tidy/checks/performance/for-range-copy.html

   48033d43dc
3. 
   DrahtBot commented at 10:55 am on December 16, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   maflcko commented at 11:21 am on December 16, 2022: member

   review ACK 48033d43dc30fcee2c9a38c828d2f58d3bc11827

   Did not test

5. maflcko renamed this:
   clang-tidy: Fix `performance-for-range-copy` in headers
   refactor: Fix `performance-for-range-copy` in headers
   on Dec 16, 2022
6. DrahtBot added the label Refactoring on Dec 16, 2022
7. 
   hebasto commented at 12:11 pm on December 16, 2022: member

   Hmm, I can’t retrieve a log from the failed CI task.
8. maflcko merged this on Dec 17, 2022
9. maflcko closed this on Dec 17, 2022

   ---

10. hebasto deleted the branch on Dec 17, 2022
11. sidhujag referenced this in commit 9f664d719e on Dec 17, 2022
12. bitcoin locked this on Dec 17, 2023

Contributors
hebasto DrahtBot maflcko

Labels
Refactoring