Bitcoin-Qt: setup testnet GUI directly #2672

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_testnet changing 3 files +47 −48

Diapolo commented at 6:27 PM on May 19, 2013: none
- this directly sets up all GUI elements that have testnet special-casing without first setting up main net stuff and chaning afterwards (titles, icons etc.)
- also fixes 2 wrong icons shown during testnet usage on our toolbar @jonasschnelli Can you take a look if testnet icon is still shown imediately on Mac?
BitcoinPullTester commented at 7:53 PM on May 19, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6eec1c80a624f594209a0b3bc464dfa914267574 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jonasschnelli commented at 7:07 AM on May 20, 2013: contributor

ACK @Diapolo looks good on mac. Started Bitcoin-Qt with -testnet. TN-Icon showed up simultaneous with the splashscreen.
laanwj commented at 10:22 AM on May 20, 2013: member

Works for me. ACK for after 0.8.2 release

Sidenote: This is all great and al, but can we start focusing on normal users again. Only a very small percentage of users will ever even see the testnet.
Diapolo commented at 3:23 PM on May 20, 2013: none

@laanwj I'm fine with your sidenode, but as I use Testnet even more often than Mainnet, I wanted to make this "perfect" ;).
in src/qt/bitcoingui.cpp:None in 6eec1c80a6 outdated
```
  65 | @@ -66,15 +66,32 @@
  66 |      rpcConsole(0),
  67 |      prevBlocks(0)
  68 |  {
  69 | +    bool fIsTestnet = GetBoolArg("-testnet", false);
```
laanwj commented at 4:30 PM on May 30, 2013:

I don't like this direct call to a core function (GetBoolArg) in GUI code. Can you pass this as a parameter to the constructor?

Diapolo commented at 11:15 AM on June 1, 2013:

Yes, I'll change that. Edit: Can you take another look?
in src/qt/bitcoingui.cpp:None in 725a6283d1 outdated
```
  54 | @@ -55,7 +55,7 @@
  55 |  
  56 |  const QString BitcoinGUI::DEFAULT_WALLET = "~Default";
  57 |  
  58 | -BitcoinGUI::BitcoinGUI(QWidget *parent) :
  59 | +BitcoinGUI::BitcoinGUI(QWidget *parent, bool fIsTestnet) :
```
Diapolo commented at 11:26 AM on June 1, 2013:

Perhaps a dumb question, but do we need QWidget here? Our main window has no parent AFAIK, or is this Qt standard and we have to keep parent in here? I'm asking because it's always 0.

laanwj commented at 5:09 PM on June 1, 2013:

The Qt convention is to put the QWidget *parent last after the other arguments, and have it default to 0. But do keep it, just for consistency.

Diapolo commented at 3:42 PM on June 2, 2013:

@laanwj Switched the bool with QWidget *, to match what you said :).
BitcoinPullTester commented at 2:21 AM on June 2, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/725a6283d1c3545a800184cf0fe5cae46f1d2fda for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Bitcoin-Qt: setup testnet GUI directly

- this directly sets up all GUI elements that have testnet special-casing
  without first setting up main net stuff and changing afterwards (titles,
  icons etc.)
- also fixes 2 wrong icons shown during testnet usage on our toolbar

80fccb0eb3

laanwj referenced this in commit fa9e5adddd on Jun 2, 2013
laanwj merged this on Jun 2, 2013
laanwj closed this on Jun 2, 2013
DrahtBot locked this on Sep 8, 2021

Contributors